Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2832153004:
[site settings] swap action menu and subpage arrow (Closed)
|
Created:
3 years, 8 months ago by dschuyler Modified:
3 years, 8 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[site settings] swap action menu and subpage arrow
This Cl moves UI elements in the content / site settings part of MD
settings. Specifically it swaps the subpage arrow and the 'three-dots'
action menu.
BUG=713918
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2832153004
Cr-Commit-Position: refs/heads/master@{#466850}
Committed: https://chromium.googlesource.com/chromium/src/+/e8adf9ff14109d9a207c8abd143ca508085702b1
Patch Set 1 : move secondary-action #
Total comments: 2
Patch Set 2 : layout #
Total comments: 1
Patch Set 3 : comment #
Messages
Total messages: 26 (21 generated)
Description was changed from ========== [site settings] swap action menu and subpage arrow This Cl moves UI elements in the content / site settings part of MD settings. Specifically it swaps the subpage arrow and the 'three-dots' action menu. BUG=713918 ========== to ========== [site settings] swap action menu and subpage arrow This Cl moves UI elements in the content / site settings part of MD settings. Specifically it swaps the subpage arrow and the 'three-dots' action menu. BUG=713918 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
https://codereview.chromium.org/2832153004/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2832153004/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_shared_css.html:351: height: 46px; I had Alan review screen shots while working on this and that's where the 36px and 46px numbers came from (from bettes@). https://codereview.chromium.org/2832153004/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/site_settings/site_list.html (right): https://codereview.chromium.org/2832153004/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/site_settings/site_list.html:83: <div class="secondary-action"></div> This div is intentionally empty. It creates a vertical grey bar when |enableSiteSettings_| is true to separate the subpage arrow from the action menu. (normally it would be a style on the following item, but that is complicated by needing to enable/disable it based on |enableSiteSettings_|, having an empty div seems cleaner than trying to turn it on/off below here).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. Just one nit. :) https://codereview.chromium.org/2832153004/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/site_settings/site_list.html (right): https://codereview.chromium.org/2832153004/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/site_settings/site_list.html:83: <div class="secondary-action"></div> Add comment to explain for future readers.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2832153004/#ps60001 (title: "comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493082013200770,
"parent_rev": "d77cac6405f78b26e5764bc23470ed088e209673", "commit_rev":
"e8adf9ff14109d9a207c8abd143ca508085702b1"}
Message was sent while issue was closed.
Description was changed from ========== [site settings] swap action menu and subpage arrow This Cl moves UI elements in the content / site settings part of MD settings. Specifically it swaps the subpage arrow and the 'three-dots' action menu. BUG=713918 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [site settings] swap action menu and subpage arrow This Cl moves UI elements in the content / site settings part of MD settings. Specifically it swaps the subpage arrow and the 'three-dots' action menu. BUG=713918 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2832153004 Cr-Commit-Position: refs/heads/master@{#466850} Committed: https://chromium.googlesource.com/chromium/src/+/e8adf9ff14109d9a207c8abd143c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/e8adf9ff14109d9a207c8abd143c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
