Move calling of shared browser test methods like SetUpOnMainThread/TearDownOnMainThread/RunTestOn...

Move calling of shared browser test methods like SetUpOnMainThread/TearDownOnMainThread/RunTestOnMainThread into the shared browser test launcher code. 

This is done because in a future change, I will add code to run in between SetUpOnMainThread and the test.

BUG=713847
Review-Url: https://codereview.chromium.org/2832153003
Cr-Commit-Position: refs/heads/master@{#466648}
Committed: https://chromium.googlesource.com/chromium/src/+/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f

[jam, 2017-04-21 22:04:03]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 22:04:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 22:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 22:22:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jam, 2017-04-21 22:38:15]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 22:38:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-04-21 22:40:24]

Description was changed from

==========
Call browser tests' SetUpOnMainThread by the browser test launcher, instead of
by subclasses.

BUG=
==========

to

==========
Move calling of shared browser test methods like
SetUpOnMainThread/TearDownOnMainThread/RunTestOnMainThread into the shared
browser test launcher code. 

This is done because in a future change, I will add code to run in between
SetUpOnMainThread and the test.

BUG=713847
==========

[jam, 2017-04-21 22:40:24]

jam@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:04:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-04-21 23:19:05]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 23:19:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:30:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jam, 2017-04-21 23:34:45]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 23:35:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-04-21 23:37:37]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 23:38:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:59:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-04-22 00:13:25]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 00:13:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-04-22 00:14:55]

https://codereview.chromium.org/2832153003/diff/100001/chrome/test/base/in_pr...
File chrome/test/base/in_process_browser_test.cc (right):

https://codereview.chromium.org/2832153003/diff/100001/chrome/test/base/in_pr...
chrome/test/base/in_process_browser_test.cc:574: disable_io_checks();
I'll do this in a followup to not make this change even larger. For now this
maintains the current behavior.

[commit-bot: I haz the power, 2017-04-22 00:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 00:46:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-04-22 00:50:58]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 00:51:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 01:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 01:24:47]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jam, 2017-04-22 15:23:06]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 15:23:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 16:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 16:20:55]

Dry run: This issue passed the CQ dry run.

[jam, 2017-04-24 15:11:40]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 15:12:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-04-24 15:36:22]

LGTM

[jam, 2017-04-24 15:48:10]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-04-24 15:48:16]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-04-24 15:49:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 16:27:11]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493048896346210,
"parent_rev": "c6cf016ecb53fa978f663d100c11e3aaa03997cc", "commit_rev":
"b3877746a0165c9eea1a3b8892ebe6c6feae8f1f"}

[commit-bot: I haz the power, 2017-04-24 16:27:28]

Description was changed from

==========
Move calling of shared browser test methods like
SetUpOnMainThread/TearDownOnMainThread/RunTestOnMainThread into the shared
browser test launcher code. 

This is done because in a future change, I will add code to run in between
SetUpOnMainThread and the test.

BUG=713847
==========

to

==========
Move calling of shared browser test methods like
SetUpOnMainThread/TearDownOnMainThread/RunTestOnMainThread into the shared
browser test launcher code. 

This is done because in a future change, I will add code to run in between
SetUpOnMainThread and the test.

BUG=713847

Review-Url: https://codereview.chromium.org/2832153003
Cr-Commit-Position: refs/heads/master@{#466648}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3877746a0165c9eea1a3b8892eb...
==========

[commit-bot: I haz the power, 2017-04-24 16:27:32]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/b3877746a0165c9eea1a3b8892eb...