Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2832133003: Roll MaterialComponents to be7b95b05d0e6257c59546a3f45264202f046e3b (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll MaterialComponents to be7b95b05d0e6257c59546a3f45264202f046e3b This CL rolls MaterialComponents to its latest version and add the new files to BUILD.gn to fix the build. BUG=714045 Review-Url: https://codereview.chromium.org/2832133003 Cr-Commit-Position: refs/heads/master@{#466304} Committed: https://chromium.googlesource.com/chromium/src/+/dc02781edef7413fc635f75bafa721e28b695ccf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ios/third_party/material_components_ios/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL. Is it the correct way to do it?
3 years, 8 months ago (2017-04-21 07:44:09 UTC) #2
lpromero
lgtm Yes, this is correct.
3 years, 8 months ago (2017-04-21 08:06:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832133003/1
3 years, 8 months ago (2017-04-21 08:06:26 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 10:27:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc02781edef7413fc635f75bafa7...

Powered by Google App Engine
This is Rietveld 408576698