Implement screen orientation for out-of-process iframes.

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index f526f7ecbd7dcf78b081974a879ef5aab921677c..5bf4e450beef2d5119d8e9de52e1e22d8fbbb37e 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1251,6 +1251,7 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
     IPC_MESSAGE_HANDLER(PageMsg_SetHistoryOffsetAndLength,
                         OnSetHistoryOffsetAndLength)
     IPC_MESSAGE_HANDLER(PageMsg_AudioStateChanged, OnAudioStateChanged)
+    IPC_MESSAGE_HANDLER(PageMsg_UpdateScreenInfo, OnUpdateScreenInfo)
 
 #if defined(OS_ANDROID)
     IPC_MESSAGE_HANDLER(ViewMsg_UpdateBrowserControlsState,
@@ -2153,11 +2154,6 @@ void RenderViewImpl::OnMediaPlayerActionAt(const gfx::Point& location,
     webview()->PerformMediaPlayerAction(action, location);
 }
 
-void RenderViewImpl::OnOrientationChange() {
-  if (webview() && webview()->MainFrame()->IsWebLocalFrame())
-    webview()->MainFrame()->ToWebLocalFrame()->SendOrientationChangeEvent();
-}
-
 void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
                                       const WebPluginAction& action) {
   if (webview())
@@ -2298,6 +2294,14 @@ void RenderViewImpl::OnPageWasShown() {
   }
 }
 
+void RenderViewImpl::OnUpdateScreenInfo(const ScreenInfo& screen_info) {
+  // This IPC only updates the screen info on RenderViews that have a remote
+  // main frame. For local main frames, the ScreenInfo is updated in
+  // ViewMsg_Resize.

[dcheng, 2017/04/25 13:10:44]

Is this something we'll be able to consolidate eventually? It's hard to follow
exactly how the various IPCs here interact to result in screen orientation
events being generated for everyone.

(Maybe the CL description could have a brief overview of how the screen
orientation change event plumbing works for both cases?)

[lfg, 2017/04/25 15:44:31]

I've implemented it this way so the OOPIF-change won't affect the way local
frames are rendered. I'm of the opinion that ScreenInfo and ResizeParams should
be decoupled, I think this is possible but its difficult (see
https://crbug.com/366848 and https://crbug.com/239624) and not something I'm
planning on tackling.
I can change that.

[dcheng, 2017/04/25 23:32:05]

It's not clear to me from the CL description how simply setting a class field
results in screen orientation events being dispatched.

+  if (!main_render_frame_)
+    screen_info_ = screen_info;
+}
+
 GURL RenderViewImpl::GetURLForGraphicsContext3D() {
   DCHECK(webview());
   if (webview()->MainFrame()->IsWebLocalFrame())