Implement screen orientation for out-of-process iframes.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
@@ skipping 1233 matching lines @@
     // Page messages.
     IPC_MESSAGE_HANDLER(PageMsg_UpdateWindowScreenRect,
                         OnUpdateWindowScreenRect)
     IPC_MESSAGE_HANDLER(PageMsg_SetZoomLevel, OnSetZoomLevel)
     IPC_MESSAGE_HANDLER(PageMsg_SetDeviceScaleFactor, OnSetDeviceScaleFactor);
     IPC_MESSAGE_HANDLER(PageMsg_WasHidden, OnPageWasHidden)
     IPC_MESSAGE_HANDLER(PageMsg_WasShown, OnPageWasShown)
     IPC_MESSAGE_HANDLER(PageMsg_SetHistoryOffsetAndLength,
                         OnSetHistoryOffsetAndLength)
     IPC_MESSAGE_HANDLER(PageMsg_AudioStateChanged, OnAudioStateChanged)
+    IPC_MESSAGE_HANDLER(PageMsg_UpdateScreenInfo, OnUpdateScreenInfo)
 
 #if defined(OS_ANDROID)
     IPC_MESSAGE_HANDLER(ViewMsg_UpdateBrowserControlsState,
                         OnUpdateBrowserControlsState)
 #elif defined(OS_MACOSX)
     IPC_MESSAGE_HANDLER(ViewMsg_GetRenderedText,
                         OnGetRenderedText)
     IPC_MESSAGE_HANDLER(ViewMsg_Close, OnClose)
 #endif
     // Adding a new message? Add platform independent ones first, then put the
@@ skipping 882 matching lines @@
     webview()->AcceptLanguagesChanged();
   }
 }
 
 void RenderViewImpl::OnMediaPlayerActionAt(const gfx::Point& location,
                                            const WebMediaPlayerAction& action) {
   if (webview())
     webview()->PerformMediaPlayerAction(action, location);
 }
 
-void RenderViewImpl::OnOrientationChange() {
-  if (webview() && webview()->MainFrame()->IsWebLocalFrame())
-    webview()->MainFrame()->ToWebLocalFrame()->SendOrientationChangeEvent();
-}
-
 void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
                                       const WebPluginAction& action) {
   if (webview())
     webview()->PerformPluginAction(action, location);
 }
 
 void RenderViewImpl::OnClosePage() {
   for (auto& observer : observers_)
     observer.ClosePage();
   // TODO(creis): We'd rather use webview()->Close() here, but that currently
@@ skipping 120 matching lines @@
 #endif
 
   if (webview()) {
     blink::WebPageVisibilityState visibilityState =
         GetMainRenderFrame() ? GetMainRenderFrame()->VisibilityState()
                              : blink::kWebPageVisibilityStateVisible;
     webview()->SetVisibilityState(visibilityState, false);
   }
 }
 
+void RenderViewImpl::OnUpdateScreenInfo(const ScreenInfo& screen_info) {
+  // This IPC only updates the screen info on RenderViews that have a remote
+  // main frame. For local main frames, the ScreenInfo is updated in
+  // ViewMsg_Resize.

[dcheng, 2017/04/25 13:10:44]

Is this something we'll be able to consolidate eventually? It's hard to follow
exactly how the various IPCs here interact to result in screen orientation
events being generated for everyone.

(Maybe the CL description could have a brief overview of how the screen
orientation change event plumbing works for both cases?)

[lfg, 2017/04/25 15:44:31]

I've implemented it this way so the OOPIF-change won't affect the way local
frames are rendered. I'm of the opinion that ScreenInfo and ResizeParams should
be decoupled, I think this is possible but its difficult (see
https://crbug.com/366848 and https://crbug.com/239624) and not something I'm
planning on tackling.
I can change that.

[dcheng, 2017/04/25 23:32:05]

It's not clear to me from the CL description how simply setting a class field
results in screen orientation events being dispatched.

+  if (!main_render_frame_)
+    screen_info_ = screen_info;
+}
+
 GURL RenderViewImpl::GetURLForGraphicsContext3D() {
   DCHECK(webview());
   if (webview()->MainFrame()->IsWebLocalFrame())
     return GURL(webview()->MainFrame()->GetDocument().Url());
   else
     return GURL("chrome://gpu/RenderViewImpl::CreateGraphicsContext3D");
 }
 
 void RenderViewImpl::OnSetFocus(bool enable) {
   // This message must always be received when the main frame is a
@@ skipping 369 matching lines @@
                         input_event.GetCoalescedEventsPointers(), latency_info,
                         dispatch_type);
     return INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
   }
   idle_user_detector_->ActivityDetected();
   return RenderWidget::HandleInputEvent(input_event, latency_info,
                                         dispatch_type);
 }
 
 }  // namespace content