Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2832063002: Fix includes for skia_paint_canvas.cc (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 8 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix includes for skia_paint_canvas.h BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2832063002 Cr-Commit-Position: refs/heads/master@{#466234} Committed: https://chromium.googlesource.com/chromium/src/+/bd700f9969f1a5e884eabf77f18b71cb601a48cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M cc/paint/skia_paint_canvas.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mthiesse
PTAL. It kind of blows my mind that this even compiles as-is.
3 years, 8 months ago (2017-04-20 23:15:59 UTC) #3
enne (OOO)
lgtm
3 years, 8 months ago (2017-04-21 01:03:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832063002/1
3 years, 8 months ago (2017-04-21 01:04:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bd700f9969f1a5e884eabf77f18b71cb601a48cd
3 years, 8 months ago (2017-04-21 02:27:38 UTC) #10
danakj
3 years, 8 months ago (2017-04-21 15:24:22 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698