Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2832023004: MD Settings: reduce amount of focus ripples shown by mouse (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: reduce amount of focus ripples shown by mouse Upstream PR for paper-icon-button(-light): https://github.com/PolymerElements/paper-icon-button/pull/111 R=dpapad@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2832023004 Cr-Commit-Position: refs/heads/master@{#466519} Committed: https://chromium.googlesource.com/chromium/src/+/1a5de509094aed3724a71314771f70a01a0584f8

Patch Set 1 : closure #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_page/compiled_resources2.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.js View 1 2 chunks +18 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/chromium.patch View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light-extracted.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Dan Beam
thoughts? maybe patch and try?
3 years, 8 months ago (2017-04-21 02:04:11 UTC) #4
dpapad
LGTM!
3 years, 8 months ago (2017-04-22 00:01:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832023004/40001
3 years, 8 months ago (2017-04-22 01:22:52 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 01:29:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1a5de509094aed3724a71314771f...

Powered by Google App Engine
This is Rietveld 408576698