Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2832023002: Replace SetUpInProcessBrowserTestFixture/TearDownInProcessBrowserTestFixture usage in content with … (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SetUpInProcessBrowserTestFixture/TearDownInProcessBrowserTestFixture usage in content with SetUpOnMainThread/TearDownOnMainThread. BUG=713847 Review-Url: https://codereview.chromium.org/2832023002 Cr-Commit-Position: refs/heads/master@{#466171} Committed: https://chromium.googlesource.com/chromium/src/+/49736bfaaee2f7f1c641daf66516ce540eddcbd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 8 months ago (2017-04-20 21:47:57 UTC) #6
sky
LGTM
3 years, 8 months ago (2017-04-20 22:21:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832023002/1
3 years, 8 months ago (2017-04-20 22:40:51 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 22:45:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49736bfaaee2f7f1c641daf66516...

Powered by Google App Engine
This is Rietveld 408576698