Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2832013002: Issue 29393. Consider 'v ??= doSomething()' as usage of 'v'. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -21 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +13 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 3 chunks +43 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-20 19:38:41 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-20 19:41:47 UTC) #2
scheglov
3 years, 8 months ago (2017-04-20 19:43:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f2061e6e34cdef1ce1754467f9f9233912a9414 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698