Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2832013002: Issue 29393. Consider 'v ??= doSomething()' as usage of 'v'. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/analysis/driver.dart ('k') | pkg/analyzer/test/generated/hint_code_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index 547e651313d9865a9ea3798c82c2a45ae0efe10a..809feb29285d7abd2bf94d809f6da29374234acc 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -3703,14 +3703,19 @@ class GatherUsedLocalElementsVisitor extends RecursiveAstVisitor {
}
// check if useless reading
AstNode parent = node.parent;
- if (parent.parent is ExpressionStatement &&
- (parent is PrefixExpression ||
- parent is PostfixExpression ||
- parent is AssignmentExpression && parent.leftHandSide == node)) {
- // v++;
- // ++v;
- // v += 2;
- return false;
+ if (parent.parent is ExpressionStatement) {
+ if (parent is PrefixExpression || parent is PostfixExpression) {
+ // v++;
+ // ++v;
+ return false;
+ }
+ if (parent is AssignmentExpression && parent.leftHandSide == node) {
+ // v ??= doSomething();
+ // vs.
+ // v += 2;
+ TokenType operatorType = parent.operator?.type;
+ return operatorType == TokenType.QUESTION_QUESTION_EQ;
+ }
}
// OK
return true;
« no previous file with comments | « pkg/analyzer/lib/src/dart/analysis/driver.dart ('k') | pkg/analyzer/test/generated/hint_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698