Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2832003003: Revert of [Payments] Normalize Shipping Address sent to merchant on Desktop. (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] Normalize Shipping Address sent to merchant on Desktop. (patchset #4 id:240001 of https://codereview.chromium.org/2829503002/ ) Reason for revert: Might have caused PaymentResponseHelperTest.GeneratePaymentResponse_* tests to fail on Mac10.9 Tests (dbg) https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/39635 Original issue's description: > [Payments] Normalize Shipping Address sent to merchant on Desktop. > > BUG=707765 > > Review-Url: https://codereview.chromium.org/2829503002 > Cr-Commit-Position: refs/heads/master@{#466226} > Committed: https://chromium.googlesource.com/chromium/src/+/64bdeb2244044a245c98c092075f750345acd9a0 TBR=anthonyvd@chromium.org,rouslan@chromium.org,sebsg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707765 Review-Url: https://codereview.chromium.org/2832003003 Cr-Commit-Position: refs/heads/master@{#466249} Committed: https://chromium.googlesource.com/chromium/src/+/1203bae1a53e9d825f2c8fdffda0083ad4c5384a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -231 lines) Patch
M chrome/browser/payments/chrome_payment_request_delegate.h View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/payments/chrome_payment_request_delegate.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M components/payments/content/payment_request_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/content/payment_response_helper.h View 3 chunks +6 lines, -23 lines 0 comments Download
M components/payments/content/payment_response_helper.cc View 3 chunks +29 lines, -70 lines 0 comments Download
M components/payments/content/payment_response_helper_unittest.cc View 10 chunks +7 lines, -40 lines 0 comments Download
M components/payments/core/address_normalizer.h View 2 chunks +5 lines, -6 lines 0 comments Download
M components/payments/core/payment_request_delegate.h View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
keishi
Created Revert of [Payments] Normalize Shipping Address sent to merchant on Desktop.
3 years, 8 months ago (2017-04-21 03:41:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832003003/1
3 years, 8 months ago (2017-04-21 03:42:20 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 03:43:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1203bae1a53e9d825f2c8fdffda0...

Powered by Google App Engine
This is Rietveld 408576698