Increase timeout for complete state for globo story

tools/perf/page_sets/system_health/browsing_stories.py

Index: tools/perf/page_sets/system_health/browsing_stories.py
diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py
index b1236f69c8195318099c54585a1220bc0b0f4dd2..e24b1e667f14c5161214575fdd2b398b088aa281 100644
--- a/tools/perf/page_sets/system_health/browsing_stories.py
+++ b/tools/perf/page_sets/system_health/browsing_stories.py
@@ -68,6 +68,8 @@ class _ArticleBrowsingStory(_BrowsingStory):
   ITEMS_TO_VISIT = 4
   MAIN_PAGE_SCROLL_REPEAT = 0
   ABSTRACT_STORY = True
+  # Some devices take long to load news webpages crbug.com/713036.
+  COMPLETE_STATE_WAIT_TIMEOUT = None

[nednguyen, 2017/04/20 20:43:43]

why not just default this to 90s
(https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...)
to avoid the awkward if else below.

[ssid, 2017/04/20 22:29:24]

I cannot import catapult/telemetry/telemetry/internal/browser/web_contents.py in
this file. So, cannot use the constant.

If someone decides to change the constant in that file in future for some
reason, and forget to change this then all syste_health stories would start
failing. That is the reason I kept it as None.

wdyt?

 
   def _DidLoadDocument(self, action_runner):
     for i in xrange(self.ITEMS_TO_VISIT):
@@ -77,7 +79,11 @@ class _ArticleBrowsingStory(_BrowsingStory):
       self._ScrollMainPage(action_runner)
 
   def _ReadNextArticle(self, action_runner):
-    action_runner.tab.WaitForDocumentReadyStateToBeComplete()
+    if self.COMPLETE_STATE_WAIT_TIMEOUT is not None:
+      action_runner.tab.WaitForDocumentReadyStateToBeComplete(
+          timeout=self.COMPLETE_STATE_WAIT_TIMEOUT)
+    else:
+      action_runner.tab.WaitForDocumentReadyStateToBeComplete()
     action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS/2.0)
     action_runner.RepeatableBrowserDrivenScroll(
         repeat_count=self.ITEM_SCROLL_REPEAT)
@@ -570,7 +576,6 @@ class BrowseTOIMobileStory(_ArticleBrowsingStory):
   ITEM_SELECTOR = '.dummy-img'
 
 
-@decorators.Disabled('android')  # crbug.com/713036.
 class BrowseGloboMobileStory(_ArticleBrowsingStory):
   NAME = 'browse:news:globo'
   URL = 'http://www.globo.com'
@@ -579,6 +584,7 @@ class BrowseGloboMobileStory(_ArticleBrowsingStory):
 
   ITEMS_TO_VISIT = 4
   ITEM_SELECTOR = '.hui-premium__title'
+  COMPLETE_STATE_WAIT_TIMEOUT = 150
 
 
 class BrowseCricBuzzMobileStory(_ArticleBrowsingStory):