Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 2831963004: md-settings: Tweak padding for action/cancel buttons and subpage header. (Closed)

Created:
3 years, 8 months ago by sammiequon
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, Dan Beam
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

md-settings: Tweak padding for action/cancel buttons and subpage header. Add left right padding to action/cancel buttons. Reduce bottom padding for settings subpage header. Also removed a todo for button opacity(saw a new value in specs). Link to specs in the bug. TEST=manual BUG=703998 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2831963004 Cr-Commit-Position: refs/heads/master@{#466545} Committed: https://chromium.googlesource.com/chromium/src/+/32d9f5075ba7f767d2c6c6d41794dc70b5ff7bf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/shared_style_css.html View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sammiequon
stevenjb@, dbeam@ - Please take a look. Thanks!
3 years, 8 months ago (2017-04-21 18:47:20 UTC) #3
stevenjb
lgtm
3 years, 8 months ago (2017-04-21 19:06:02 UTC) #4
Dan Beam
lgtm thanks for the split!
3 years, 8 months ago (2017-04-21 23:32:48 UTC) #5
sammiequon
Thanks!
3 years, 8 months ago (2017-04-22 03:59:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831963004/1
3 years, 8 months ago (2017-04-22 03:59:42 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 19:17:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32d9f5075ba7f767d2c6c6d41794...

Powered by Google App Engine
This is Rietveld 408576698