Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2831953002: Update TestExpectations and rebase some tests. (Closed)

Created:
3 years, 8 months ago by Stephen Chennney
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestExpectations and rebase some tests. Try reducing flakes for images/color-profile-reflection.html by switching to runAfterLayoutAndPaint. Rebaseline canvas drawing tests after path tesselation patch landed. Remove expectations for no-longer-failing images/color-profile-reflection.html and virtual/gpu/fast/canvas/canvas-ImageData-neutered-source.html TBR=junov@chromium.org BUG=642376, 706375, 713049, 713462 Review-Url: https://codereview.chromium.org/2831953002 Cr-Commit-Position: refs/heads/master@{#466120} Committed: https://chromium.googlesource.com/chromium/src/+/3182feed58c8d7838cf85f3f4b620606ea06f7a5

Patch Set 1 #

Patch Set 2 : New baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 4 chunks +9 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-reflection.html View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png View 1 Binary file 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831953002/20001
3 years, 8 months ago (2017-04-20 19:33:47 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:52:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3182feed58c8d7838cf85f3f4b62...

Powered by Google App Engine
This is Rietveld 408576698