Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2831933003:
Use generated copy and compare for OriginalDisplay in ComputedStyle. (Closed)
DescriptionUse generated copy and compare for OriginalDisplay in ComputedStyle.
The original_display_ field in ComputedStyle currently has generated
storage, but not copy and compare. This patch makes it use generated
copy and compare. Previously, 'has_custom_compare_and_copy' was set
to true, so the generator did not generate a compare and copy for
OriginalDisplay. By removing that line, we fall back to the default
value of false, which means the generator will now generate a
compare and copy.
This patch does not change behaviour, as the newly generated code is
the same as the code being removed.
Diff of generated files:
https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2831933003
Cr-Commit-Position: refs/heads/master@{#467818}
Committed: https://chromium.googlesource.com/chromium/src/+/a0d005f4f1d364bb312aeb25cbbea0d82a980a26
Patch Set 1 #Patch Set 2 : Rebase #
Dependent Patchsets: Messages
Total messages: 28 (20 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + bugsnash@chromium.org
Hi Bugs, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2017/04/21 at 03:53:47, shend wrote: > Hi Bugs, PTAL Please add to description changes in generated files and explain why it is ok to use the generated copy and compare functions for OriginalDisplay now
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. We are able to do this now because we have added the 'has_custom_compare_and_copy' parameter in a previous patch. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
On 2017/04/24 at 00:32:42, bugsnash wrote: > On 2017/04/21 at 03:53:47, shend wrote: > > Hi Bugs, PTAL > > Please add to description changes in generated files and explain why it is ok to use the generated copy and compare functions for OriginalDisplay now Done.
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. We are able to do this now because we have added the 'has_custom_compare_and_copy' parameter in a previous patch. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy. By removing that line, we fall back to the default value of 'false', which means the generator will now generate a compare and copy. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy. By removing that line, we fall back to the default value of 'false', which means the generator will now generate a compare and copy. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of 'false', which means the generator will now generate a compare and copy. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of 'false', which means the generator will now generate a compare and copy. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of false, which means the generator will now generate a compare and copy. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
lgtm
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of false, which means the generator will now generate a compare and copy. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of false, which means the generator will now generate a compare and copy. This patch does not change behaviour, as the newly generated code is the same as the code being removed. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + alancutter@chromium.org
Hi Alan, PTAL :)
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493332176563300,
"parent_rev": "c7a827953ea89e6c314956119514fa3acd69eba6", "commit_rev":
"a0d005f4f1d364bb312aeb25cbbea0d82a980a26"}
Message was sent while issue was closed.
Description was changed from ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of false, which means the generator will now generate a compare and copy. This patch does not change behaviour, as the newly generated code is the same as the code being removed. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 ========== to ========== Use generated copy and compare for OriginalDisplay in ComputedStyle. The original_display_ field in ComputedStyle currently has generated storage, but not copy and compare. This patch makes it use generated copy and compare. Previously, 'has_custom_compare_and_copy' was set to true, so the generator did not generate a compare and copy for OriginalDisplay. By removing that line, we fall back to the default value of false, which means the generator will now generate a compare and copy. This patch does not change behaviour, as the newly generated code is the same as the code being removed. Diff of generated files: https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2831933003 Cr-Commit-Position: refs/heads/master@{#467818} Committed: https://chromium.googlesource.com/chromium/src/+/a0d005f4f1d364bb312aeb25cbbe... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a0d005f4f1d364bb312aeb25cbbe... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
