Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2831923003: Disable tests to fix contextual property access (Closed)

Created:
3 years, 8 months ago by Toon Verwaest
Modified:
3 years, 7 months ago
Reviewers:
haraken, kinuko
CC:
chromium-reviews, blink-reviews, falken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable tests to fix contextual property access. This is required to land https://chromium-review.googlesource.com/c/483199/ which changes the behavior. Currently those tests hardwire wrong behavior that exposes internal implementation details. The change in the referred CL makes it more uniform, and in line with at least Firefox. BUG=chromium:713732 Review-Url: https://codereview.chromium.org/2831923003 Cr-Commit-Position: refs/heads/master@{#467965} Committed: https://chromium.googlesource.com/chromium/src/+/50d4cffe6fc36e4852ec2cb77a33e93d7beb5a51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Toon Verwaest
ptal
3 years, 8 months ago (2017-04-26 11:55:36 UTC) #2
haraken
LGTM (I discussed offline with Toon.) - Would you add more explanation to the CL ...
3 years, 8 months ago (2017-04-26 12:09:08 UTC) #3
Toon Verwaest
Added a comment. I've already asked on the linked bug a week ago, but didn't ...
3 years, 8 months ago (2017-04-26 12:14:38 UTC) #5
kinuko
From the bug discussion I believe this (and the actual change) is fine. We'll revise ...
3 years, 7 months ago (2017-04-28 06:02:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831923003/1
3 years, 7 months ago (2017-04-28 09:17:34 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 12:10:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50d4cffe6fc36e4852ec2cb77a33...

Powered by Google App Engine
This is Rietveld 408576698