Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2831853002: Re-land: Finish implementation of automation API hit testing for the desktop (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, kalyank, sadrul, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, je_julie, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Finish implementation of automation API hit testing for the desktop Original change: r465716 https://codereview.chromium.org/2813083003/ Reverted: r465839 https://codereview.chromium.org/2827103003/ The original change failed due to "test produced excessive output". Fixed by running final test callback only once. This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate so that you can send a hit test request on the root of the whole automation tree and get a hit test on either views or web content. Switches Select-to-speak to use this new API. A follow-up change will change the way select-to-speak works so that it sends the mouse event to the extension and the hit test comes from there, but this is a self-contained change that can land first. BUG=699617 TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2831853002 Cr-Commit-Position: refs/heads/master@{#465930} Committed: https://chromium.googlesource.com/chromium/src/+/6c4193276b6a8a8ccbd75c1e514317a815f90e85

Patch Set 1 #

Patch Set 2 : Fix to trigger final test callback only once #

Messages

Total messages: 6 (3 generated)
dmazzoni
3 years, 8 months ago (2017-04-20 05:46:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831853002/20001
3 years, 8 months ago (2017-04-20 05:47:25 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 07:02:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6c4193276b6a8a8ccbd75c1e5143...

Powered by Google App Engine
This is Rietveld 408576698