Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2831783002: bluetooth: Clean up better 'not connected' errors (Closed)

Created:
3 years, 8 months ago by ortuno
Modified:
3 years, 8 months ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Clean up better 'not connected' errors Removes obsolete TODO and changes the name of GATT to kGATT to match other enums. BUG=684445 Review-Url: https://codereview.chromium.org/2831783002 Cr-Commit-Position: refs/heads/master@{#467216} Committed: https://chromium.googlesource.com/chromium/src/+/672c108a285f4e8a3e9f4705af5b488cac4d8010

Patch Set 1 #

Patch Set 2 : Fix enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
ortuno
scheib: PTAL
3 years, 8 months ago (2017-04-19 21:55:16 UTC) #3
scheib
lgtm
3 years, 8 months ago (2017-04-21 06:08:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831783002/20001
3 years, 8 months ago (2017-04-21 06:08:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/436209)
3 years, 8 months ago (2017-04-21 07:28:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831783002/20001
3 years, 8 months ago (2017-04-25 22:13:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/438894)
3 years, 8 months ago (2017-04-26 00:06:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831783002/20001
3 years, 8 months ago (2017-04-26 01:54:46 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 02:56:36 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/672c108a285f4e8a3e9f4705af5b...

Powered by Google App Engine
This is Rietveld 408576698