Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2831763003: Unified error handling for WritableStream (Closed)

Created:
3 years, 8 months ago by Adam Rice
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Unified error handling for WritableStream Port the standard changes in https://github.com/whatwg/streams/pull/721. There are a number of behavioural changes related to error handling, which are listed at the above URL. This implementation has no known deviations from the standard. The brings this implementation up to parity with https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db8c32. The version of this CL merged to M59 branch 3071 adds failing and time-out test expectations since the tests on hte branch are now out-of-date with respect to the implementation. See http://crbug.com/713664. BUG=711254, 684543 Review-Url: https://codereview.chromium.org/2823563002 Cr-Commit-Position: refs/heads/master@{#465498} (cherry picked from commit 6703f4df6ad92a629ea4ac736f6ff26402ef139e) Review-Url: https://codereview.chromium.org/2831763003 . Cr-Commit-Position: refs/branch-heads/3071@{#82} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f703afd1326015ab595fb8e857df55c765f0c9e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+818 lines, -432 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +11 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.dedicatedworker-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.serviceworker.https-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.sharedworker-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward-expected.txt View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.dedicatedworker-expected.txt View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.serviceworker.https-expected.txt View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.sharedworker-expected.txt View 2 chunks +16 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.dedicatedworker-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.serviceworker.https-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.sharedworker-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/general-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.dedicatedworker-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.serviceworker.https-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.sharedworker-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.dedicatedworker-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.serviceworker.https-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.sharedworker-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.dedicatedworker-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.serviceworker.https-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.sharedworker-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.dedicatedworker-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.serviceworker.https-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.sharedworker-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.dedicatedworker-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.serviceworker.https-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.sharedworker-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.dedicatedworker-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.serviceworker.https-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.sharedworker-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.dedicatedworker-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.serviceworker.https-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.sharedworker-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.js View 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/streams/WritableStream.js View 24 chunks +233 lines, -189 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Adam Rice
3 years, 8 months ago (2017-04-20 13:19:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f703afd1326015ab595fb8e857df55c765f0c9e7.

Powered by Google App Engine
This is Rietveld 408576698