Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2831763002: Fix SurfaceIds in mus with surface sync off. (Closed)

Created:
3 years, 8 months ago by kylechar
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, Fady Samuel
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SurfaceIds in mus with surface sync off. WindowPortMus was sending SurfaceIds (a) too early and (b) that weren't the right SurfaceId causing lots of log spam with mus and surface sync turned off. BUG=711544 Review-Url: https://codereview.chromium.org/2831763002 Cr-Commit-Position: refs/heads/master@{#465767} Committed: https://chromium.googlesource.com/chromium/src/+/8761c218a237d2bd6ea05547ad5e578de0a9a855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/aura/mus/window_port_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
kylechar
3 years, 8 months ago (2017-04-19 20:54:57 UTC) #2
sky
LGTM
3 years, 8 months ago (2017-04-19 20:56:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831763002/1
3 years, 8 months ago (2017-04-19 20:58:13 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 21:54:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8761c218a237d2bd6ea05547ad5e...

Powered by Google App Engine
This is Rietveld 408576698