Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2831743002: Use PKCS7_get_raw_certificates in x509_certificate_bytes.cc. (Closed)

Created:
3 years, 8 months ago by davidben
Modified:
3 years, 8 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PKCS7_get_raw_certificates in x509_certificate_bytes.cc. This removes a dependency on the legacy X.509 stack. BUG=706445 Review-Url: https://codereview.chromium.org/2831743002 Cr-Commit-Position: refs/heads/master@{#465760} Committed: https://chromium.googlesource.com/chromium/src/+/9cf9295d43d7aee7b837e17b185e9cf80958f81e

Patch Set 1 #

Patch Set 2 : derp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M net/cert/x509_certificate_bytes.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
davidben
3 years, 8 months ago (2017-04-19 20:09:51 UTC) #4
mattm
lgtm, thanks!
3 years, 8 months ago (2017-04-19 20:59:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831743002/20001
3 years, 8 months ago (2017-04-19 21:24:12 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 21:34:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9cf9295d43d7aee7b837e17b185e...

Powered by Google App Engine
This is Rietveld 408576698