Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2831733005: Enable frame pointers explicitly under ARM32. (Closed)

Created:
3 years, 8 months ago by Wez
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Enable frame pointers explicitly under ARM32. This replaces the quick-fix in crrev.com/2820803003, to address issues with ARM32 builds when frame pointers are disabled. This CL explicitly enables frame pointers in ARM32 builds, and pulls out the ARM32 and ARM64 special-cases to be handling separately from Debug, profiling and sanitizer build configurations, for clarity. BUG=710131, 706654, 711784 Review-Url: https://codereview.chromium.org/2829433003 Cr-Commit-Position: refs/heads/master@{#466080} (cherry picked from commit 38f02400540606a7c418f9fa5148d3a07fd8b4fa) Review-Url: https://codereview.chromium.org/2831733005 . Cr-Commit-Position: refs/branch-heads/3071@{#98} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1e22c07d34fdb782f532155ae5fca2f048a5e2f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 chunk +25 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Wez
3 years, 8 months ago (2017-04-20 20:47:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e22c07d34fdb782f532155ae5fca2f048a5e2f3.

Powered by Google App Engine
This is Rietveld 408576698