Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2831713002: Revert of [Mac] Support for Touch Bar Customization (Closed)

Created:
3 years, 8 months ago by spqchan
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, srahim+watch_chromium.org, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Support for Touch Bar Customization (patchset #8 id:180001 of https://codereview.chromium.org/2814683005/ ) Reason for revert: Broke the 10.12 build Original issue's description: > [Mac] Support for Touch Bar Customization > > Implement customization support for the default touch > bar. Changed the item identifiers to reverse-DNS style format. > > BUG=710100 > > Review-Url: https://codereview.chromium.org/2814683005 > Cr-Commit-Position: refs/heads/master@{#464967} > Committed: https://chromium.googlesource.com/chromium/src/+/1ad3c00f56fbf19ecba52bdf0591ca7ad1098d3a TBR=rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=710100 Review-Url: https://codereview.chromium.org/2831713002 Cr-Commit-Position: refs/heads/master@{#465705} Committed: https://chromium.googlesource.com/chromium/src/+/4b18d5f5e02254c2f2088570e66c74db7eeb8e38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -105 lines) Patch
M base/mac/sdk_forward_declarations.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -20 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_touch_bar.mm View 8 chunks +36 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
spqchan
Created Revert of [Mac] Support for Touch Bar Customization
3 years, 8 months ago (2017-04-19 18:38:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831713002/1
3 years, 8 months ago (2017-04-19 18:39:38 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:26:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b18d5f5e02254c2f2088570e66c...

Powered by Google App Engine
This is Rietveld 408576698