Chromium Code Reviews
DescriptionMerge "cros: Fix unlock crash with multi-display"
> SessionController::RunUnlockAnimation expects the callback to be
> invoked only once. SessionStateAnimatorImpl uses the callback per
> animation per container. Mulit-display would have multiple containers
> involved hence multiple animation and callbacks. The multiple
> callback would cause a mojo CHECK failure. SessionStateAnimator
> should only run the callback once after all animations finish.
> The CL use a BarrierClosure to combine the animation callbacks.
>
> BUG=712422
> TEST=SessionStateAnimatiorImplContainersTest.AnimationCallbackOnMultiDisplay
>
> Review-Url: https://codereview.chromium.org/2823343006
> Cr-Commit-Position: refs/heads/master@{#465670}
> (cherry picked from commit 52558bf8b2796a8e97c73a2351e23a1f8c45e423)
Review-Url: https://codereview.chromium.org/2831703003 .
Cr-Commit-Position: refs/branch-heads/3071@{#91}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/b2a474304aa38cbdf585d72f1600eabd82010914
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||