Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2831703003: Merge "cros: Fix unlock crash with multi-display" (Closed)

Created:
3 years, 8 months ago by xiyuan
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "cros: Fix unlock crash with multi-display" > SessionController::RunUnlockAnimation expects the callback to be > invoked only once. SessionStateAnimatorImpl uses the callback per > animation per container. Mulit-display would have multiple containers > involved hence multiple animation and callbacks. The multiple > callback would cause a mojo CHECK failure. SessionStateAnimator > should only run the callback once after all animations finish. > The CL use a BarrierClosure to combine the animation callbacks. > > BUG=712422 > TEST=SessionStateAnimatiorImplContainersTest.AnimationCallbackOnMultiDisplay > > Review-Url: https://codereview.chromium.org/2823343006 > Cr-Commit-Position: refs/heads/master@{#465670} > (cherry picked from commit 52558bf8b2796a8e97c73a2351e23a1f8c45e423) Review-Url: https://codereview.chromium.org/2831703003 . Cr-Commit-Position: refs/branch-heads/3071@{#91} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b2a474304aa38cbdf585d72f1600eabd82010914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M ash/wm/session_state_animator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/session_state_animator_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/wm/session_state_animator_impl_unittest.cc View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 8 months ago (2017-04-20 18:26:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2a474304aa38cbdf585d72f1600eabd82010914.

Powered by Google App Engine
This is Rietveld 408576698