Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2831663002: Use flat_set in SurfaceAggregator. (Closed)

Created:
3 years, 8 months ago by brettw
Modified:
3 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use flat_set in SurfaceAggregator. The sets and maps are typically small or empty and created once. flat_set and flat_map will have better performance for these workloads. See the bug for histograms of sizes. Reland of https://codereview.chromium.org/2821353002 with fix. Reland of https://codereview.chromium.org/2823043002 with fix. BUG=712295 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=jbauman@chromium.org Review-Url: https://codereview.chromium.org/2831663002 Cr-Commit-Position: refs/heads/master@{#465681} Committed: https://chromium.googlesource.com/chromium/src/+/8dd06bbc3fd157da89a7ed820b306d39ebea64e2

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -38 lines) Patch
M cc/surfaces/surface_aggregator.h View 7 chunks +12 lines, -18 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 11 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brettw
Fix
3 years, 8 months ago (2017-04-19 17:47:13 UTC) #1
brettw
One more non-stable iterator I had to change. The original landing is in PS1.
3 years, 8 months ago (2017-04-19 17:47:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831663002/20001
3 years, 8 months ago (2017-04-19 17:48:32 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:53:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8dd06bbc3fd157da89a7ed820b30...

Powered by Google App Engine
This is Rietveld 408576698