Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2831633002: [ObjC ARC] Converts ios/public/provider/chrome/browser/images:images to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/public/provider/chrome/browser/images:images to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2831633002 Cr-Commit-Position: refs/heads/master@{#465923} Committed: https://chromium.googlesource.com/chromium/src/+/a33bf9e1f2b315799a05aa8fbf8a736f1ceb7d10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/images/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/images/branded_image_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-19 16:13:21 UTC) #4
sdefresne
lgtm
3 years, 8 months ago (2017-04-19 16:35:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831633002/1
3 years, 8 months ago (2017-04-20 06:44:34 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 06:48:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a33bf9e1f2b315799a05aa8fbf8a...

Powered by Google App Engine
This is Rietveld 408576698