Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2720)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/shell/test_runner/web_frame_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index ebdb9309f7c3770715f1adb6b5716b092958725b..f68037c8104cdb78070279905363a1603f1e36ed 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3803,29 +3803,27 @@ void RenderFrameImpl::DidCreateNewDocument(blink::WebLocalFrame* frame) {
observer.DidCreateNewDocument(frame);
}
-void RenderFrameImpl::DidClearWindowObject(blink::WebLocalFrame* frame) {
- DCHECK_EQ(frame_, frame);
-
+void RenderFrameImpl::DidClearWindowObject() {
if (enabled_bindings_ & BINDINGS_POLICY_WEB_UI)
- WebUIExtension::Install(frame);
+ WebUIExtension::Install(frame_);
if (enabled_bindings_ & BINDINGS_POLICY_DOM_AUTOMATION)
- DomAutomationController::Install(this, frame);
+ DomAutomationController::Install(this, frame_);
if (enabled_bindings_ & BINDINGS_POLICY_STATS_COLLECTION)
- StatsCollectionController::Install(frame);
+ StatsCollectionController::Install(frame_);
const base::CommandLine& command_line =
*base::CommandLine::ForCurrentProcess();
if (command_line.HasSwitch(cc::switches::kEnableGpuBenchmarking))
- GpuBenchmarking::Install(frame);
+ GpuBenchmarking::Install(frame_);
if (command_line.HasSwitch(switches::kEnableSkiaBenchmarking))
- SkiaBenchmarking::Install(frame);
+ SkiaBenchmarking::Install(frame_);
for (auto& observer : render_view_->observers())
- observer.DidClearWindowObject(frame);
+ observer.DidClearWindowObject(frame_);
for (auto& observer : observers_)
observer.DidClearWindowObject();
}
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/shell/test_runner/web_frame_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698