Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2831503002: Move WebBlob.cpp from web/ -> core/exported/. (Closed)

Created:
3 years, 8 months ago by slangley
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebBlob.cpp from web/ -> core/exported/. This cl moves WebBlob.cpp from web/ into core/exported/. As WebBlob.cpp has no dependencies in web/ and is expose via public/web/ it makes a good choice to be the first class moved into core/exported, so we can ensure that all of the link dependencies are correctly setup to build the entire chrome binary. BUG=712963 Review-Url: https://codereview.chromium.org/2831503002 Cr-Commit-Position: refs/heads/master@{#465560} Committed: https://chromium.googlesource.com/chromium/src/+/ea3f0631136037f49339894dc5e08d797f9bd628

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : Remove compile time definition. #

Patch Set 4 : Fix indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -98 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/exported/BUILD.gn View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/exported/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebBlob.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/web/WebBlob.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
slangley
3 years, 8 months ago (2017-04-19 06:37:20 UTC) #5
slangley
3 years, 8 months ago (2017-04-19 06:37:21 UTC) #6
slangley
Fixes the indentation in the DEPS file.
3 years, 8 months ago (2017-04-19 06:43:54 UTC) #7
haraken
LGTM
3 years, 8 months ago (2017-04-19 07:29:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831503002/60001
3 years, 8 months ago (2017-04-19 09:37:51 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 12:17:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ea3f0631136037f49339894dc5e0...

Powered by Google App Engine
This is Rietveld 408576698