Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2831473002: Add a callback parameter to UpdateClient::SendUninstallPing. (Closed)

Created:
3 years, 8 months ago by Sorin Jianu
Modified:
3 years, 8 months ago
Reviewers:
waffles, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a callback parameter to UpdateClient::SendUninstallPing. This is a mechanical change. This refactoring is needed for future work and it resolves an issue with the UpdateClientTest::SendUninstallPing, where the test is missing the RunThreads() call at the end. This change makes the UpdateClient API consistent, since all non-blocking APIs now take a callback parameter. Review-Url: https://codereview.chromium.org/2831473002 Cr-Commit-Position: refs/heads/master@{#465632} Committed: https://chromium.googlesource.com/chromium/src/+/8037ac8c239b75a76ba3392dcbae14bbb046c080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M components/component_updater/component_updater_service_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M components/update_client/update_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/update_client.cc View 2 chunks +5 lines, -1 line 0 comments Download
M components/update_client/update_client_internal.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/update_client_unittest.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M extensions/browser/updater/update_service.cc View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/updater/update_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Sorin Jianu
Hi Devlin, PTAL! Thank you!
3 years, 8 months ago (2017-04-19 16:04:42 UTC) #6
Devlin
extensions lgtm
3 years, 8 months ago (2017-04-19 16:16:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831473002/1
3 years, 8 months ago (2017-04-19 16:21:54 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:28:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8037ac8c239b75a76ba3392dcbae...

Powered by Google App Engine
This is Rietveld 408576698