Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2831443002: Simplify CrasAudioHandler code. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
jennyz
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify CrasAudioHandler code. - Add helper functions like GetCrasAudioClient(). - Remove else after returns. - Fix misc style nits. Review-Url: https://codereview.chromium.org/2831443002 Cr-Commit-Position: refs/heads/master@{#465442} Committed: https://chromium.googlesource.com/chromium/src/+/ab84818703b820d9596a9637a91f73e64096f5b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -93 lines) Patch
M chromeos/audio/cras_audio_handler.cc View 22 chunks +66 lines, -93 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
3 years, 8 months ago (2017-04-18 23:11:02 UTC) #2
jennyz
lgtm
3 years, 8 months ago (2017-04-18 23:43:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831443002/1
3 years, 8 months ago (2017-04-18 23:48:51 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 00:39:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab84818703b820d9596a9637a91f...

Powered by Google App Engine
This is Rietveld 408576698