Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2831383003: Delete "Net.UnspecResolvedIPv6" histogram (Closed)

Created:
3 years, 8 months ago by mgersh
Modified:
3 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete "Net.UnspecResolvedIPv6" histogram This looks it was a short-term experiment from 2013 that never got cleaned up. It's not in histograms.xml. BUG=643567 Review-Url: https://codereview.chromium.org/2831383003 Cr-Commit-Position: refs/heads/master@{#466458} Committed: https://chromium.googlesource.com/chromium/src/+/d7b04a2c8accc7f3c2061fd991186dd176575bc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M net/dns/host_resolver_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mgersh
3 years, 8 months ago (2017-04-21 20:03:02 UTC) #2
mmenke
LGTM, thanks for the cleanup!
3 years, 8 months ago (2017-04-21 20:05:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831383003/1
3 years, 8 months ago (2017-04-21 20:06:37 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 21:49:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7b04a2c8accc7f3c2061fd99118...

Powered by Google App Engine
This is Rietveld 408576698