Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and StoreSavesP…

Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and StoreSavesPSLMatchedCredential

navigator.credentials.get is dispatched via Mojo from renderer to browser. The test should wait for this call to be processed. Here is an example of the failure.

[ RUN      ] CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation
[38019:771:0421/041104.591122:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[38019:59655:0421/041105.028129:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/credential_manager_browsertest.cc:80: Failure
Value of: PasswordsModelDelegateFromWebContents(WebContents())->GetState()
  Actual: 3
Expected: password_manager::ui::CREDENTIAL_REQUEST_STATE
Which is: 4

BUG=629459
Review-Url: https://codereview.chromium.org/2831343002
Cr-Commit-Position: refs/heads/master@{#466326}
Committed: https://chromium.googlesource.com/chromium/src/+/9728e1c00831de324f4b65643b5f837d74785590

[vasilii, 2017-04-21 13:35:38]

Description was changed from

==========
Fix flaky
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and
StoreSavesPSLMatchedCredential

navigator.credentials.get is dispatched via Mojo from renderer to browser. The
test should wait for this call to be processed.

BUG=629459
==========

to

==========
Fix flaky
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and
StoreSavesPSLMatchedCredential

navigator.credentials.get is dispatched via Mojo from renderer to browser. The
test should wait for this call to be processed. Here is an example of the
failure.

[ RUN      ]
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation
[38019:771:0421/041104.591122:WARNING:ipc_message_attachment_set.cc(49)]
MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[38019:59655:0421/041105.028129:WARNING:embedded_test_server.cc(219)] Request
not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/credential_manager_browsertest.cc:80:
Failure
Value of: PasswordsModelDelegateFromWebContents(WebContents())->GetState()
  Actual: 3
Expected: password_manager::ui::CREDENTIAL_REQUEST_STATE
Which is: 4

BUG=629459
==========

[vasilii, 2017-04-21 13:35:38]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2017-04-21 13:36:00]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 13:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-04-21 13:36:10]

Hi Vaclav,

please review

[vabr (Chromium), 2017-04-21 13:46:38]

LGTM, thanks!
Vaclav

[vasilii, 2017-04-21 13:53:12]

The CQ bit was unchecked by vasilii@chromium.org

[vasilii, 2017-04-21 13:53:17]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-04-21 13:53:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:14:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492782797575470, "parent_rev":
"35629b9c2d21ae7af4ec8ebdcec1c2c21a042880", "commit_rev":
"9728e1c00831de324f4b65643b5f837d74785590"}

[commit-bot: I haz the power, 2017-04-21 14:14:53]

Description was changed from

==========
Fix flaky
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and
StoreSavesPSLMatchedCredential

navigator.credentials.get is dispatched via Mojo from renderer to browser. The
test should wait for this call to be processed. Here is an example of the
failure.

[ RUN      ]
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation
[38019:771:0421/041104.591122:WARNING:ipc_message_attachment_set.cc(49)]
MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[38019:59655:0421/041105.028129:WARNING:embedded_test_server.cc(219)] Request
not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/credential_manager_browsertest.cc:80:
Failure
Value of: PasswordsModelDelegateFromWebContents(WebContents())->GetState()
  Actual: 3
Expected: password_manager::ui::CREDENTIAL_REQUEST_STATE
Which is: 4

BUG=629459
==========

to

==========
Fix flaky
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and
StoreSavesPSLMatchedCredential

navigator.credentials.get is dispatched via Mojo from renderer to browser. The
test should wait for this call to be processed. Here is an example of the
failure.

[ RUN      ]
CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation
[38019:771:0421/041104.591122:WARNING:ipc_message_attachment_set.cc(49)]
MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[38019:59655:0421/041105.028129:WARNING:embedded_test_server.cc(219)] Request
not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/credential_manager_browsertest.cc:80:
Failure
Value of: PasswordsModelDelegateFromWebContents(WebContents())->GetState()
  Actual: 3
Expected: password_manager::ui::CREDENTIAL_REQUEST_STATE
Which is: 4

BUG=629459

Review-Url: https://codereview.chromium.org/2831343002
Cr-Commit-Position: refs/heads/master@{#466326}
Committed:
https://chromium.googlesource.com/chromium/src/+/9728e1c00831de324f4b65643b5f...
==========

[commit-bot: I haz the power, 2017-04-21 14:14:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9728e1c00831de324f4b65643b5f...