Show the drop down menu on the screen the mouse cursor is on

Show the drop down menu on the screen the mouse cursor is on

A browser window might be positioned over the edge between two screens. In that
case we try to show the drop down menu on the screen the mouse cursor is on, but
this does not work as expected on Windows. To achieve this, we obtain the bounds
of the screen the mouse cursor is on, and then adjust the position of the drop
down menu so that the menu stays within that bounds. But on Windows, we use the
bounding rectangle of all display monitors instead of a specific monitor, and
this leads to a different outcome than we expected. This CL fixes this problem.

BUG=713690
Review-Url: https://codereview.chromium.org/2831323002
Cr-Commit-Position: refs/heads/master@{#466866}
Committed: https://chromium.googlesource.com/chromium/src/+/4b19ed9075339cea26ea01d00de0d8e8c1035884

[Sungmann Cho, 2017-04-21 11:31:48]

sungmann.cho@navercorp.com changed reviewers:
+ pkasting@chromium.org

[Sungmann Cho, 2017-04-21 11:31:49]

Please take a look. Thanks!

[Peter Kasting, 2017-04-24 18:36:07]

pkasting@chromium.org changed reviewers:
+ robliao@chromium.org

[Peter Kasting, 2017-04-24 18:36:07]

+robliao to review since he would have a better idea than me of whether this is
the right fix, but it looks reasonable to me.  LGTM as OWNER once he signs off.

[robliao, 2017-04-24 21:51:31]

On 2017/04/24 18:36:07, Peter Kasting (catching up) wrote:
> +robliao to review since he would have a better idea than me of whether this
is
> the right fix, but it looks reasonable to me.  LGTM as OWNER once he signs
off.

This code (https://codereview.chromium.org/19516) predated now effective
bounding code below (https://codereview.chromium.org/157843003).

The bounding code below seems reasonable and suggests someone came up with a
policy to have the menu where the cursor appears for other platforms.
However, this now introduces an interesting behavior where if the menu is
activated via keyboard, where it displays is dependent on the cursor location.
This should be an issue today on other platforms.

lgtm.

[Sungmann Cho, 2017-04-25 01:07:17]

> However, this now introduces an interesting behavior where if the menu is
> activated via keyboard, where it displays is dependent on the cursor location.
> This should be an issue today on other platforms.

It seems that |source_type| of ToolbarButton::ShowDropDownMenu() makes it
possible to see whether the menu is activated via keyboard or not. I'll take a
look at this. Thanks for the review!

[Sungmann Cho, 2017-04-25 01:07:23]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2017-04-25 01:07:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 01:56:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493082443448830, "parent_rev":
"71d4e23d28ddebf95392cb2cbb635ce3270c79a0", "commit_rev":
"4b19ed9075339cea26ea01d00de0d8e8c1035884"}

[commit-bot: I haz the power, 2017-04-25 01:56:07]

Description was changed from

==========
Show the drop down menu on the screen the mouse cursor is on

A browser window might be positioned over the edge between two screens. In that
case we try to show the drop down menu on the screen the mouse cursor is on, but
this does not work as expected on Windows. To achieve this, we obtain the bounds
of the screen the mouse cursor is on, and then adjust the position of the drop
down menu so that the menu stays within that bounds. But on Windows, we use the
bounding rectangle of all display monitors instead of a specific monitor, and
this leads to a different outcome than we expected. This CL fixes this problem.

BUG=713690
==========

to

==========
Show the drop down menu on the screen the mouse cursor is on

A browser window might be positioned over the edge between two screens. In that
case we try to show the drop down menu on the screen the mouse cursor is on, but
this does not work as expected on Windows. To achieve this, we obtain the bounds
of the screen the mouse cursor is on, and then adjust the position of the drop
down menu so that the menu stays within that bounds. But on Windows, we use the
bounding rectangle of all display monitors instead of a specific monitor, and
this leads to a different outcome than we expected. This CL fixes this problem.

BUG=713690

Review-Url: https://codereview.chromium.org/2831323002
Cr-Commit-Position: refs/heads/master@{#466866}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b19ed9075339cea26ea01d00de0...
==========

[commit-bot: I haz the power, 2017-04-25 01:56:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b19ed9075339cea26ea01d00de0...