Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2831273003: Change name of recently introduced metric Memory.Gpu.PhysicalFootprint.MacOS. (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change name of recently introduced metric Memory.Gpu.PhysicalFootprint.MacOS. The new name is Memory.Experimental.Gpu.PhysicalFootprint.MacOS, to reflect the temporary nature of the histogram. BUG=713854 Review-Url: https://codereview.chromium.org/2831273003 Cr-Commit-Position: refs/heads/master@{#466465} Committed: https://chromium.googlesource.com/chromium/src/+/5ee3686ce72a6f6f4e218984f80e230f88760115

Patch Set 1 #

Patch Set 2 : Reformat tools/metrics/histograms/histograms.xml. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/metrics/metrics_memory_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
erikchen
asvitkine: Please review histograms.xml
3 years, 8 months ago (2017-04-21 19:49:59 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 8 months ago (2017-04-21 19:51:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831273003/20001
3 years, 8 months ago (2017-04-21 20:04:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/410799)
3 years, 8 months ago (2017-04-21 20:37:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831273003/20001
3 years, 8 months ago (2017-04-21 20:41:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 22:20:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ee3686ce72a6f6f4e218984f80e...

Powered by Google App Engine
This is Rietveld 408576698