Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 2831263003: Gate sending referrers to CWS on whether the profile has SafeBrowsing enabled. (Closed)

Created:
3 years, 8 months ago by robertshield
Modified:
3 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gate sending referrers to CWS on whether the profile has SafeBrowsing enabled. BUG=714129 Review-Url: https://codereview.chromium.org/2831263003 Cr-Commit-Position: refs/heads/master@{#466402} Committed: https://chromium.googlesource.com/chromium/src/+/a603f32b1aa3556586f75909a2c73d3006b92edf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Devlin feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M chrome/browser/extensions/webstore_inline_installer.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 3 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
robertshield
3 years, 8 months ago (2017-04-21 13:58:01 UTC) #4
Devlin
lgtm https://codereview.chromium.org/2831263003/diff/1/chrome/browser/extensions/webstore_inline_installer.cc File chrome/browser/extensions/webstore_inline_installer.cc (right): https://codereview.chromium.org/2831263003/diff/1/chrome/browser/extensions/webstore_inline_installer.cc#newcode115 chrome/browser/extensions/webstore_inline_installer.cc:115: Profile::FromBrowserContext(web_contents()->GetBrowserContext()); nit: looks like WebstoreStandaloneInstaller has a profile() ...
3 years, 8 months ago (2017-04-21 17:09:43 UTC) #7
robertshield
https://codereview.chromium.org/2831263003/diff/1/chrome/browser/extensions/webstore_inline_installer.cc File chrome/browser/extensions/webstore_inline_installer.cc (right): https://codereview.chromium.org/2831263003/diff/1/chrome/browser/extensions/webstore_inline_installer.cc#newcode115 chrome/browser/extensions/webstore_inline_installer.cc:115: Profile::FromBrowserContext(web_contents()->GetBrowserContext()); On 2017/04/21 17:09:43, Devlin wrote: > nit: looks ...
3 years, 8 months ago (2017-04-21 18:02:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831263003/20001
3 years, 8 months ago (2017-04-21 18:55:47 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 18:59:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a603f32b1aa3556586f75909a2c7...

Powered by Google App Engine
This is Rietveld 408576698