Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 2831233004: predictors: Add resource type to manifest.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 17 hours ago by alexilin
Modified:
12 hours, 38 minutes ago
Reviewers:
Benoit L
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Add resource type to manifest. This CL adds a new resource type field to the manifest proto. ResourcePrefetchPredictor begins to use this field to prefetch all resources of one resource type before another. Also we prioritize stylesheets above scripts since this CL. Stylesheets are almost always critical, scripts are not. It's clear win in the case if we're fetching resources from manifests because we don't have information about request priority in manifests. Thus we can't separate critical scripts from non-critical ones. BUG=699115

Patch Set 1 #

Total comments: 10

Patch Set 2 : Use the same resource type ordering. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -99 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.cc View 3 chunks +21 lines, -5 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.proto View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 6 chunks +49 lines, -21 lines 1 comment Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 1 4 chunks +43 lines, -14 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 12 chunks +68 lines, -43 lines 0 comments Download
M components/precache/core/proto/precache.proto View 1 chunk +14 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (4 generated)
alexilin
Hi Benoit! PTAL. https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor_tables.cc File chrome/browser/predictors/resource_prefetch_predictor_tables.cc (left): https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor_tables.cc#oldcode318 chrome/browser/predictors/resource_prefetch_predictor_tables.cc:318: for (auto& kv : *data_map) { ...
5 days, 17 hours ago (2017-04-21 12:07:28 UTC) #2
alexilin
ping lizeb.com PING lizeb.com (184.168.221.51) 56(84) bytes of data. 64 bytes from ip-184-168-221-51.ip.secureserver.net (184.168.221.51): icmp_seq=1 ...
1 day, 20 hours ago (2017-04-25 08:39:53 UTC) #3
Benoit L
On 2017/04/25 08:39:53, alexilin wrote: > ping http://lizeb.com > > PING http://lizeb.com (184.168.221.51) 56(84) bytes ...
1 day, 20 hours ago (2017-04-25 08:43:16 UTC) #4
Benoit L
https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode1001 chrome/browser/predictors/resource_prefetch_predictor.cc:1001: return ResourcePrefetchPredictorTables::ComputePrecacheResourceScore( nit: use a local "using" to make ...
1 day, 20 hours ago (2017-04-25 08:59:21 UTC) #5
alexilin
A couple of questions before I send the next patch. https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode1001 ...
1 day, 16 hours ago (2017-04-25 13:04:26 UTC) #6
Benoit L
https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode1001 chrome/browser/predictors/resource_prefetch_predictor.cc:1001: return ResourcePrefetchPredictorTables::ComputePrecacheResourceScore( On 2017/04/25 13:04:25, alexilin wrote: > On ...
1 day, 14 hours ago (2017-04-25 15:12:39 UTC) #7
alexilin
https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2831233004/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode1001 chrome/browser/predictors/resource_prefetch_predictor.cc:1001: return ResourcePrefetchPredictorTables::ComputePrecacheResourceScore( On 2017/04/25 15:12:39, Benoit L wrote: > ...
1 day, 11 hours ago (2017-04-25 17:37:05 UTC) #11
alexilin
12 hours, 53 minutes ago (2017-04-26 16:29:36 UTC) #12
Friendly ping.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46