[Home] Set soft input mode based on sheet state

[Home] Set soft input mode based on sheet state

This change fixes the content jumping problem experienced in Chrome
Home when navigating with a focused omnibox. Normally, when the
omnibox gets focus, the input mode is changed to SOFT_INPUT_ADJUST_PAN
and not changed back until defocusing is complete. This causes a
problem if the omnibox is moving (i.e. Chrome Home). In the Chrome
Home version, while defocusing, the input mode is immediately changed
to *_NOTHING. When the sheet reaches the peek state, the mode is
changed back to *_RESIZE. The deferring of the mode change prevents
the content jump.

BUG=706918
Review-Url: https://codereview.chromium.org/2831233002
Cr-Commit-Position: refs/heads/master@{#466357}
Committed: https://chromium.googlesource.com/chromium/src/+/0d5af94346c215cb917920baced6c06bb9110e61

[mdjones, 2017-04-20 21:32:18]

mdjones@chromium.org changed reviewers:
+ tedchoc@chromium.org

[mdjones, 2017-04-20 21:32:18]

ptal

[mdjones, 2017-04-20 21:32:57]

Description was changed from

==========
[Home] Set soft input mode based on sheet state

This change fixes the content jumping problem experienced in Chrome
Home when navigating with a focused omnibox. Normally, when the
omnibox gets focus, the input mode is changed to SOFT_INPUT_ADJUST_PAN
and not changed back until defocusing is complete. This causes a
problem if the omnibox is moving (i.e. Chrome Home). In the Chrome
Home version, while defocusing, the input mode is immediately changed
to *_NOTHING. When the sheet reaches the peek state, the mode is
changed back to *_RESIZE. The deferring of the mode change prevents
the content jump.

BUG=706918

[Home] Delay setting soft input mode
==========

to

==========
[Home] Set soft input mode based on sheet state

This change fixes the content jumping problem experienced in Chrome
Home when navigating with a focused omnibox. Normally, when the
omnibox gets focus, the input mode is changed to SOFT_INPUT_ADJUST_PAN
and not changed back until defocusing is complete. This causes a
problem if the omnibox is moving (i.e. Chrome Home). In the Chrome
Home version, while defocusing, the input mode is immediately changed
to *_NOTHING. When the sheet reaches the peek state, the mode is
changed back to *_RESIZE. The deferring of the mode change prevents
the content jump.

BUG=706918
==========

[Ted C, 2017-04-20 22:54:57]

lgtm

https://codereview.chromium.org/2831233002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
(right):

https://codereview.chromium.org/2831233002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java:193:
if (mKeyboardResizeModeTask != null) {
I think we should remove this from here and put it in setSoftInputMode (before
the initial softInputMode equality check).

https://codereview.chromium.org/2831233002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java:311:
if (mKeyboardResizeModeTask != null) return;
I think we should be able to remove this with my above comment

[mdjones, 2017-04-21 00:22:46]

https://codereview.chromium.org/2831233002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
(right):

https://codereview.chromium.org/2831233002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java:193:
if (mKeyboardResizeModeTask != null) {
On 2017/04/20 22:54:56, Ted C wrote:
> I think we should remove this from here and put it in setSoftInputMode (before
> the initial softInputMode equality check).

Done.

https://codereview.chromium.org/2831233002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java:311:
if (mKeyboardResizeModeTask != null) return;
On 2017/04/20 22:54:56, Ted C wrote:
> I think we should be able to remove this with my above comment

Done.

[mdjones, 2017-04-21 00:23:17]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-04-21 00:23:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2831233002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-04-21 00:23:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 00:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 00:25:57]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mdjones, 2017-04-21 16:18:10]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-21 16:18:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 16:27:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492791490233300,
"parent_rev": "95ccac2b64390b1d688ad151b09f9374a7aece73", "commit_rev":
"0d5af94346c215cb917920baced6c06bb9110e61"}

[commit-bot: I haz the power, 2017-04-21 16:27:19]

Description was changed from

==========
[Home] Set soft input mode based on sheet state

This change fixes the content jumping problem experienced in Chrome
Home when navigating with a focused omnibox. Normally, when the
omnibox gets focus, the input mode is changed to SOFT_INPUT_ADJUST_PAN
and not changed back until defocusing is complete. This causes a
problem if the omnibox is moving (i.e. Chrome Home). In the Chrome
Home version, while defocusing, the input mode is immediately changed
to *_NOTHING. When the sheet reaches the peek state, the mode is
changed back to *_RESIZE. The deferring of the mode change prevents
the content jump.

BUG=706918
==========

to

==========
[Home] Set soft input mode based on sheet state

This change fixes the content jumping problem experienced in Chrome
Home when navigating with a focused omnibox. Normally, when the
omnibox gets focus, the input mode is changed to SOFT_INPUT_ADJUST_PAN
and not changed back until defocusing is complete. This causes a
problem if the omnibox is moving (i.e. Chrome Home). In the Chrome
Home version, while defocusing, the input mode is immediately changed
to *_NOTHING. When the sheet reaches the peek state, the mode is
changed back to *_RESIZE. The deferring of the mode change prevents
the content jump.

BUG=706918

Review-Url: https://codereview.chromium.org/2831233002
Cr-Commit-Position: refs/heads/master@{#466357}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d5af94346c215cb917920baced6...
==========

[commit-bot: I haz the power, 2017-04-21 16:27:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d5af94346c215cb917920baced6...