Move the onclose event handler to the FakeUSBDevice object

Move the onclose event handler to the FakeUSBDevice object

This updates the WebUSB Testing API polyfill to put the onclose event
handler on the FakeUSBDevice object which makes tests a little simpler.

BUG=705734
Review-Url: https://codereview.chromium.org/2831223003
Cr-Commit-Position: refs/heads/master@{#466774}
Committed: https://chromium.googlesource.com/chromium/src/+/34237a69cf404e36413627836b4a5e501759dafd

[Reilly Grant (use Gerrit), 2017-04-20 22:42:32]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-04-20 22:42:49]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2017-04-20 22:43:19]

reillyg@chromium.org changed reviewers:
+ mcasas@chromium.org

[Reilly Grant (use Gerrit), 2017-04-20 22:43:20]

PTAL

[commit-bot: I haz the power, 2017-04-20 22:44:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:46:47]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mcasas, 2017-04-21 02:02:35]

lgtm w/ an idea.

https://codereview.chromium.org/2831223003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/usb/resources/webusb-test.js (right):

https://codereview.chromium.org/2831223003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/usb/resources/webusb-test.js:396: this.onclose =
null;
I  think JS initializes all onBla event listeners to null,
if so this is redundant.

[Reilly Grant (use Gerrit), 2017-04-24 19:29:15]

https://codereview.chromium.org/2831223003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/usb/resources/webusb-test.js (right):

https://codereview.chromium.org/2831223003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/usb/resources/webusb-test.js:396: this.onclose =
null;
On 2017/04/21 02:02:35, mcasas wrote:
> I  think JS initializes all onBla event listeners to null,
> if so this is redundant.

I need to write an actual polyfill EventTarget implementation that implements
both addEventListener and EventHandler attributes correctly. This code just uses
it as a normal attribute so I have to initialize.

[Reilly Grant (use Gerrit), 2017-04-24 19:29:30]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-04-24 19:30:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 19:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 19:35:43]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Reilly Grant (use Gerrit), 2017-04-24 20:19:31]

Rebased

[Reilly Grant (use Gerrit), 2017-04-24 20:22:09]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 20:22:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-04-24 20:27:07]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-04-24 20:27:11]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-04-24 20:27:11]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2831223003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-04-24 20:28:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:35:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493065631322730,
"parent_rev": "5cf00322124a19db68f811f0c2740243c48ac6cb", "commit_rev":
"34237a69cf404e36413627836b4a5e501759dafd"}

[commit-bot: I haz the power, 2017-04-24 21:35:18]

Description was changed from

==========
Move the onclose event handler to the FakeUSBDevice object

This updates the WebUSB Testing API polyfill to put the onclose event
handler on the FakeUSBDevice object which makes tests a little simpler.

BUG=705734
==========

to

==========
Move the onclose event handler to the FakeUSBDevice object

This updates the WebUSB Testing API polyfill to put the onclose event
handler on the FakeUSBDevice object which makes tests a little simpler.

BUG=705734

Review-Url: https://codereview.chromium.org/2831223003
Cr-Commit-Position: refs/heads/master@{#466774}
Committed:
https://chromium.googlesource.com/chromium/src/+/34237a69cf404e36413627836b4a...
==========

[commit-bot: I haz the power, 2017-04-24 21:35:19]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/34237a69cf404e36413627836b4a...