Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 2831213005: [ObjC ARC] Converts ios/chrome/browser/ui/infobars:infobars to ARC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by gambard
Modified:
4 months ago
Reviewers:
jif
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/infobars:infobars to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2831213005 Cr-Commit-Position: refs/heads/master@{#466353} Committed: https://chromium.googlesource.com/chromium/src/+/bedb9d4efb97106bed60b6db89b675928d1d6850

Patch Set 1 #

Patch Set 2 : Fix weaks #

Total comments: 11

Patch Set 3 : Remove weak #

Messages

Total messages: 21 (12 generated)
gambard
PTAL.
4 months ago (2017-04-21 10:51:09 UTC) #8
jif
https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm File ios/chrome/browser/ui/infobars/infobar_view.mm (right): https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode227 ios/chrome/browser/ui/infobars/infobar_view.mm:227: InfoBarViewDelegate* delegate_; // weak. __weak https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode245 ios/chrome/browser/ui/infobars/infobar_view.mm:245: __weak UILabel* ...
4 months ago (2017-04-21 11:21:14 UTC) #9
gambard
https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm File ios/chrome/browser/ui/infobars/infobar_view.mm (right): https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode227 ios/chrome/browser/ui/infobars/infobar_view.mm:227: InfoBarViewDelegate* delegate_; // weak. On 2017/04/21 11:21:14, jif wrote: ...
4 months ago (2017-04-21 11:38:18 UTC) #10
jif
https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm File ios/chrome/browser/ui/infobars/infobar_view.mm (right): https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode245 ios/chrome/browser/ui/infobars/infobar_view.mm:245: __weak UILabel* label_; On 2017/04/21 11:38:18, gambard wrote: > ...
4 months ago (2017-04-21 12:29:21 UTC) #13
gambard
Thanks, PTAL. https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm File ios/chrome/browser/ui/infobars/infobar_view.mm (right): https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode245 ios/chrome/browser/ui/infobars/infobar_view.mm:245: __weak UILabel* label_; On 2017/04/21 12:29:20, jif ...
4 months ago (2017-04-21 13:40:54 UTC) #14
jif
lgtm https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm File ios/chrome/browser/ui/infobars/infobar_view.mm (right): https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode227 ios/chrome/browser/ui/infobars/infobar_view.mm:227: InfoBarViewDelegate* delegate_; // weak. On 2017/04/21 11:38:18, gambard ...
4 months ago (2017-04-21 14:13:56 UTC) #15
gambard
https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm File ios/chrome/browser/ui/infobars/infobar_view.mm (right): https://codereview.chromium.org/2831213005/diff/20001/ios/chrome/browser/ui/infobars/infobar_view.mm#newcode227 ios/chrome/browser/ui/infobars/infobar_view.mm:227: InfoBarViewDelegate* delegate_; // weak. On 2017/04/21 14:13:56, jif wrote: ...
4 months ago (2017-04-21 15:00:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831213005/40001
4 months ago (2017-04-21 15:00:53 UTC) #18
commit-bot: I haz the power
4 months ago (2017-04-21 16:07:21 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bedb9d4efb97106bed60b6db89b6...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b