Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2831203002: Fix LayoutObject::SetSubtreeNeedsPaintPropertyUpdate() to set ancestor flags (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LayoutObject::SetSubtreeNeedsPaintPropertyUpdate() to set ancestor flags BUG=713503 Review-Url: https://codereview.chromium.org/2831203002 Cr-Commit-Position: refs/heads/master@{#466194} Committed: https://chromium.googlesource.com/chromium/src/+/e715cb02c568dc66f7a6db7b216c616ae22d7017

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Xianzhu
https://codereview.chromium.org/2831203002/diff/1/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right): https://codereview.chromium.org/2831203002/diff/1/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp#newcode268 third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:268: if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && This is for the test to ...
3 years, 8 months ago (2017-04-20 21:01:14 UTC) #4
pdr.
LGTM
3 years, 8 months ago (2017-04-20 23:02:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831203002/1
3 years, 8 months ago (2017-04-20 23:20:45 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 00:04:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e715cb02c568dc66f7a6db7b216c...

Powered by Google App Engine
This is Rietveld 408576698