[Telemetry] Move chrome tracing agent exceptions to use telemetry.core.exceptions

[Telemetry] Move chrome tracing agent exceptions to use telemetry.core.exceptions

BUG=catapult:#3509

Review-Url: https://codereview.chromium.org/2831193002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4d4343808af0ecf365e4a789add07c30d17f6b0e

[rnephew (Reviews Here), 2017-04-20 20:46:36]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 20:46:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rnephew (Reviews Here), 2017-04-20 20:49:14]

rnephew@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2017-04-20 20:56:53]

Can you add test coverage for this (probably something similar to
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

I recall in the past some of these were unrecoverable because we failed to turn
the tracing_controller state from "started" to "stopped". The next run can only
succeed if tracing_controller state is reset to "stopped" properly.

[commit-bot: I haz the power, 2017-04-20 21:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:48:37]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[rnephew (Reviews Here), 2017-04-20 21:53:25]

On 2017/04/20 20:56:53, nednguyen wrote:
> Can you add test coverage for this (probably something similar to
>
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...
> 
> I recall in the past some of these were unrecoverable because we failed to
turn
> the tracing_controller state from "started" to "stopped". The next run can
only
> succeed if tracing_controller state is reset to "stopped" properly.

I think there is already a test in chrome_tracing_agent_unittests that covers
this.

https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

Let me know if I'm misunderstanding what you want me to add a test to cover or
if I misunderstand what that test is covering.

[nednguyen, 2017-04-20 22:32:32]

On 2017/04/20 21:53:25, rnephew (Reviews Here) wrote:
> On 2017/04/20 20:56:53, nednguyen wrote:
> > Can you add test coverage for this (probably something similar to
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...
> > 
> > I recall in the past some of these were unrecoverable because we failed to
> turn
> > the tracing_controller state from "started" to "stopped". The next run can
> only
> > succeed if tracing_controller state is reset to "stopped" properly.
> 
> I think there is already a test in chrome_tracing_agent_unittests that covers
> this.
> 
>
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...
> 
> Let me know if I'm misunderstanding what you want me to add a test to cover or
> if I misunderstand what that test is covering.

Ah, I didn't realize that we have the test for ChromeTracingStoppedError
already. I think we still need similar tests for ChromeTracingStartedError &
ChromeClockSyncError

[rnephew (Reviews Here), 2017-04-21 20:56:52]

On 2017/04/20 22:32:32, nednguyen wrote:
> On 2017/04/20 21:53:25, rnephew (Reviews Here) wrote:
> > On 2017/04/20 20:56:53, nednguyen wrote:
> > > Can you add test coverage for this (probably something similar to
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...
> > > 
> > > I recall in the past some of these were unrecoverable because we failed to
> > turn
> > > the tracing_controller state from "started" to "stopped". The next run can
> > only
> > > succeed if tracing_controller state is reset to "stopped" properly.
> > 
> > I think there is already a test in chrome_tracing_agent_unittests that
covers
> > this.
> > 
> >
>
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...
> > 
> > Let me know if I'm misunderstanding what you want me to add a test to cover
or
> > if I misunderstand what that test is covering.
> 
> Ah, I didn't realize that we have the test for ChromeTracingStoppedError
> already. I think we still need similar tests for ChromeTracingStartedError &
> ChromeClockSyncError

Added unit tests for ChromeTracingStartedError and ChromeClockSyncError as well
as expanded the other existing unit tests to include the clock sycning step.

[nednguyen, 2017-04-21 23:27:26]

lgtm

[rnephew (Reviews Here), 2017-04-21 23:33:58]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:34:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:58:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492817638364670,
"parent_rev": "b5b525957fba7bd8fce6908b02df49f0d7e0992c", "commit_rev":
"4d4343808af0ecf365e4a789add07c30d17f6b0e"}

[commit-bot: I haz the power, 2017-04-21 23:58:03]

Description was changed from

==========
[Telemetry] Move chrome tracing agent exceptions to use
telemetry.core.exceptions

BUG=catapult:#3509
==========

to

==========
[Telemetry] Move chrome tracing agent exceptions to use
telemetry.core.exceptions

BUG=catapult:#3509

Review-Url: https://codereview.chromium.org/2831193002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-04-21 23:58:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...