Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2831143002: Updating usage notes for remoting_breakpad_tester (Closed)

Created:
3 years, 8 months ago by joedow
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating usage notes for remoting_breakpad_tester In order for this tool to work, the current user must have permission to inject a thread into the remoting_{host|desktop} process it is targeting. This permission is only granted (by default) to system. An admin can modify the privileges of running processes via procexp but it is simpler to tell them to run the exe as SYSTEM. BUG= Review-Url: https://codereview.chromium.org/2831143002 Cr-Commit-Position: refs/heads/master@{#466144} Committed: https://chromium.googlesource.com/chromium/src/+/900ad0ccf5cc4e9a4cc899cd45960e2f6f2cd8da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M remoting/tools/breakpad_tester_win.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
joedow
PTAL!
3 years, 8 months ago (2017-04-20 19:14:07 UTC) #3
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-20 21:20:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831143002/1
3 years, 8 months ago (2017-04-20 21:26:50 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 21:31:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/900ad0ccf5cc4e9a4cc899cd4596...

Powered by Google App Engine
This is Rietveld 408576698