Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2831073003: Reland of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (Closed)

Created:
3 years, 8 months ago by fmeawad
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-grc-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), oystein (OOO til 10th of July), qsr+mojo_chromium.org, tracing+reviews_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (patchset #1 id:1 of https://codereview.chromium.org/2828333002/ ) Reason for revert: Reland as is: The bot seems to have been flaky Original issue's description: > Revert of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (patchset #5 id:80001 of https://codereview.chromium.org/2822593002/ ) > > Reason for revert: > Suspecting CL that caused compile failure in > https://build.chromium.org/p/chromium/builders/Win/builds/54274. > > Need to monitor whether the Win build goes back to green after reverting. > > Original issue's description: > > [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback > > > > This CL is a follow up CL to http://crrev.com/277709300 where we add the missing > > extra_processes_dump map from the MemoryDumpCallbackResult struct into its > > corresponding mojo struct. > > > > BUG=703184 > > > > Review-Url: https://codereview.chromium.org/2822593002 > > Cr-Commit-Position: refs/heads/master@{#466021} > > Committed: https://chromium.googlesource.com/chromium/src/+/33bb7a42b9ea6c9138ac975e35b0242b9da21c07 > > TBR=mkwst@chromium.org,hjd@chromium.org,primiano@chromium.org,rockot@chromium.org,fmeawad@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=703184 > > Review-Url: https://codereview.chromium.org/2828333002 > Cr-Commit-Position: refs/heads/master@{#466047} > Committed: https://chromium.googlesource.com/chromium/src/+/b0886512757808f5a6747dbf31b7fb0ada721740 TBR=mkwst@chromium.org,hjd@chromium.org,primiano@chromium.org,rockot@chromium.org,xlai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703184 Review-Url: https://codereview.chromium.org/2831073003 Cr-Commit-Position: refs/heads/master@{#466061} Committed: https://chromium.googlesource.com/chromium/src/+/4cacbef5155a1553ace1f76ca4f846f42f51b44a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -12 lines) Patch
M base/trace_event/memory_dump_manager.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/common/common_custom_types_struct_traits.h View 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/common/common_custom_types_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
A mojo/common/process_id.mojom View 1 chunk +12 lines, -0 lines 0 comments Download
A mojo/common/process_id.typemap View 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h View 2 chunks +8 lines, -0 lines 0 comments Download
M services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
fmeawad
Created Reland of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback
3 years, 8 months ago (2017-04-20 17:52:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831073003/1
3 years, 8 months ago (2017-04-20 17:52:38 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:53:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4cacbef5155a1553ace1f76ca4f8...

Powered by Google App Engine
This is Rietveld 408576698