Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2831063002: Don't shrink the message center height while open (Closed)

Created:
3 years, 8 months ago by yoshiki
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't shrink the message center height while open Previously, the height of the message center shrank if necessary. But this patch changed this behavior and made it not shrank while the message center opens. This patch also changes animation. Previously, the notifications above the target were animated. With this patch, the notifications below the target are animated. This is because now we don't update the height of message center so animating below is natural. The reason why we don't use AnimateNotificationsBelowTarget() is that it has a bug on removing notification. BUG=709337 BUG=b/36517819 TEST=manual TEST=unittests pass Review-Url: https://codereview.chromium.org/2805143002 Cr-Commit-Position: refs/heads/master@{#465184} (cherry picked from commit 8057405c22f4ca9727ab53b845ee87ed1d865a73) Review-Url: https://codereview.chromium.org/2831063002 . Cr-Commit-Position: refs/branch-heads/3071@{#79} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4595f544ddf229fe129c50b890b672073206e33b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -110 lines) Patch
M ui/message_center/views/message_center_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M ui/message_center/views/message_list_view.h View 5 chunks +12 lines, -3 lines 0 comments Download
M ui/message_center/views/message_list_view.cc View 10 chunks +62 lines, -24 lines 0 comments Download
M ui/message_center/views/message_list_view_unittest.cc View 1 chunk +70 lines, -70 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yoshiki
3 years, 8 months ago (2017-04-20 08:42:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4595f544ddf229fe129c50b890b672073206e33b.

Powered by Google App Engine
This is Rietveld 408576698