Chromium Code Reviews
DescriptionDon't shrink the message center height while open
Previously, the height of the message center shrank if necessary. But this patch changed this behavior and made it not shrank while the message center opens.
This patch also changes animation. Previously, the notifications above the target were animated. With this patch, the notifications below the target are animated. This is because now we don't update the height of message center so animating below is natural.
The reason why we don't use AnimateNotificationsBelowTarget() is that it has a bug on removing notification.
BUG=709337
BUG=b/36517819
TEST=manual
TEST=unittests pass
Review-Url: https://codereview.chromium.org/2805143002
Cr-Commit-Position: refs/heads/master@{#465184}
(cherry picked from commit 8057405c22f4ca9727ab53b845ee87ed1d865a73)
Review-Url: https://codereview.chromium.org/2831063002 .
Cr-Commit-Position: refs/branch-heads/3071@{#79}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/4595f544ddf229fe129c50b890b672073206e33b
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||