Refactor AddScrollListItem() in system menu detailed views

ash/system/tray/tray_popup_utils.cc

Index: ash/system/tray/tray_popup_utils.cc
diff --git a/ash/system/tray/tray_popup_utils.cc b/ash/system/tray/tray_popup_utils.cc
index d5bdd0a69e1abc1c8e05e6287ca0868c2c26de7c..b883d874182ee262d2820160b6fb1b03e6e9b6b6 100644
--- a/ash/system/tray/tray_popup_utils.cc
+++ b/ash/system/tray/tray_popup_utils.cc
@@ -174,10 +174,12 @@ TriView* TrayPopupUtils::CreateDefaultRowView() {
   return tri_view;
 }
 
-TriView* TrayPopupUtils::CreateSubHeaderRowView() {
+TriView* TrayPopupUtils::CreateSubHeaderRowView(bool hide_start) {

[tdanderson, 2017/04/24 15:43:39]

I see you have made mention of this in your CL description, but maybe it is
worth adding a TODO for anyone who stumbles across this, along the lines of "Do
not call this directly, use TrayDetailsView::AddScrollListSubHeader() instead.
TODO(mohsen): Move this function out of TrayPopupUtils and into TrayDetailsView
once network and VPN use TrayDetailsView::AddScrollListSubHeader()" or similar.

[mohsen, 2017/04/25 05:10:01]

Well, I was not thinking of deleting this. Thought it might still be useful for
places that want to create a sub-header row with similar layout in classes that
are not necessarily inheriting TrayDetailsView. But, probably the only usage for
this function would be in detailed views. So, done!

   TriView* tri_view = CreateMultiTargetRowView();
-  tri_view->SetInsets(gfx::Insets(0, kTrayPopupPaddingHorizontal, 0, 0));
-  tri_view->SetContainerVisible(TriView::Container::START, false);
+  if (hide_start) {
+    tri_view->SetInsets(gfx::Insets(0, kTrayPopupPaddingHorizontal, 0, 0));
+    tri_view->SetContainerVisible(TriView::Container::START, false);
+  }
   tri_view->SetContainerLayout(
       TriView::Container::END,
       CreateDefaultLayoutManager(TriView::Container::END));