Refactor AddScrollListItem() in system menu detailed views

ash/system/tray/tray_popup_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/tray_popup_utils.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "ash/ash_constants.h"
@@ skipping 156 matching lines @@
   tri_view->SetContainerLayout(
       TriView::Container::CENTER,
       CreateDefaultLayoutManager(TriView::Container::CENTER));
   tri_view->SetContainerLayout(
       TriView::Container::END,
       CreateDefaultLayoutManager(TriView::Container::END));
 
   return tri_view;
 }
 
-TriView* TrayPopupUtils::CreateSubHeaderRowView() {
+TriView* TrayPopupUtils::CreateSubHeaderRowView(bool hide_start) {

[tdanderson, 2017/04/24 15:43:39]

I see you have made mention of this in your CL description, but maybe it is
worth adding a TODO for anyone who stumbles across this, along the lines of "Do
not call this directly, use TrayDetailsView::AddScrollListSubHeader() instead.
TODO(mohsen): Move this function out of TrayPopupUtils and into TrayDetailsView
once network and VPN use TrayDetailsView::AddScrollListSubHeader()" or similar.

[mohsen, 2017/04/25 05:10:01]

Well, I was not thinking of deleting this. Thought it might still be useful for
places that want to create a sub-header row with similar layout in classes that
are not necessarily inheriting TrayDetailsView. But, probably the only usage for
this function would be in detailed views. So, done!

   TriView* tri_view = CreateMultiTargetRowView();
-  tri_view->SetInsets(gfx::Insets(0, kTrayPopupPaddingHorizontal, 0, 0));
-  tri_view->SetContainerVisible(TriView::Container::START, false);
+  if (hide_start) {
+    tri_view->SetInsets(gfx::Insets(0, kTrayPopupPaddingHorizontal, 0, 0));
+    tri_view->SetContainerVisible(TriView::Container::START, false);
+  }
   tri_view->SetContainerLayout(
       TriView::Container::END,
       CreateDefaultLayoutManager(TriView::Container::END));
   return tri_view;
 }
 
 views::View* TrayPopupUtils::CreateInfoLabelRowView(int message_id) {
   views::Label* label = TrayPopupUtils::CreateDefaultLabel();
   label->SetText(l10n_util::GetStringUTF16(message_id));
   TrayPopupItemStyle style(TrayPopupItemStyle::FontStyle::SYSTEM_INFO);
@@ skipping 265 matching lines @@
 
 void TrayPopupUtils::UpdateCheckMarkVisibility(HoverHighlightView* container,
                                                bool visible) {
   container->SetRightViewVisible(visible);
   container->SetAccessiblityState(
       visible ? HoverHighlightView::AccessibilityState::CHECKED_CHECKBOX
               : HoverHighlightView::AccessibilityState::UNCHECKED_CHECKBOX);
 }
 
 }  // namespace ash