Plugin Power Saver: Remove racy portion of tests.

Plugin Power Saver: Remove racy portion of tests.

The removed lines are racy, since it's possible that sometimes the
browser process has not received the 'blocked plugin' message from the
renderer yet.

It would be pretty tricky to coordinate, and I think not worth it.
This test should focus on the PPS aspects specifically anyways.

BUG=682039, 680544
Review-Url: https://codereview.chromium.org/2831003003
Cr-Commit-Position: refs/heads/master@{#466126}
Committed: https://chromium.googlesource.com/chromium/src/+/e510ebfc9f8565fc8cec92955b631aae49c17fd3

[tommycli, 2017-04-20 18:40:06]

Description was changed from

==========
Plugin Power Saver: Remove racy portion of tests.

The removed lines are racy, since it's possible that sometimes the
browser process has not received the 'blocked plugin' message from the
renderer yet.

It would be pretty tricky to coordinate, and I think not worth it.
This test should focus on the PPS aspects specifically anyways.

BUG=682039
==========

to

==========
Plugin Power Saver: Remove racy portion of tests.

The removed lines are racy, since it's possible that sometimes the
browser process has not received the 'blocked plugin' message from the
renderer yet.

It would be pretty tricky to coordinate, and I think not worth it.
This test should focus on the PPS aspects specifically anyways.

BUG=682039,680544
==========

[tommycli, 2017-04-20 18:42:13]

tommycli@chromium.org changed reviewers:
+ thestig@chromium.org

[tommycli, 2017-04-20 18:42:14]

thestig: PTAL, thanks!

https://codereview.chromium.org/2831003003/diff/1/chrome/browser/plugins/plug...
File chrome/browser/plugins/plugin_power_saver_browsertest.cc (left):

https://codereview.chromium.org/2831003003/diff/1/chrome/browser/plugins/plug...
chrome/browser/plugins/plugin_power_saver_browsertest.cc:576:
EXPECT_FALSE(tab_specific_content_settings->blocked_plugin_names().empty());
This portion never flaked by coincidence, since VerifyPluginMarkedEssential
waited on some stuff from the renderer long enough to always win the race...

However, once FilterSameOriginTinyPlugin feature is enabled by default, we are
going to consolidate the two tests, so it's worth just removing this racy
portion now.

[tommycli, 2017-04-20 18:42:22]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 18:43:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 19:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:48:18]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-20 20:53:33]

lgtm

[tommycli, 2017-04-20 20:53:49]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-04-20 20:53:55]

On 2017/04/20 20:53:33, Lei Zhang wrote:
> lgtm

thanks@

[commit-bot: I haz the power, 2017-04-20 20:54:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:59:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492721629520160, "parent_rev":
"cd90c4719b46692c8eee8279cf1dc8894356845a", "commit_rev":
"e510ebfc9f8565fc8cec92955b631aae49c17fd3"}

[commit-bot: I haz the power, 2017-04-20 20:59:58]

Description was changed from

==========
Plugin Power Saver: Remove racy portion of tests.

The removed lines are racy, since it's possible that sometimes the
browser process has not received the 'blocked plugin' message from the
renderer yet.

It would be pretty tricky to coordinate, and I think not worth it.
This test should focus on the PPS aspects specifically anyways.

BUG=682039,680544
==========

to

==========
Plugin Power Saver: Remove racy portion of tests.

The removed lines are racy, since it's possible that sometimes the
browser process has not received the 'blocked plugin' message from the
renderer yet.

It would be pretty tricky to coordinate, and I think not worth it.
This test should focus on the PPS aspects specifically anyways.

BUG=682039,680544

Review-Url: https://codereview.chromium.org/2831003003
Cr-Commit-Position: refs/heads/master@{#466126}
Committed:
https://chromium.googlesource.com/chromium/src/+/e510ebfc9f8565fc8cec92955b63...
==========

[commit-bot: I haz the power, 2017-04-20 20:59:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e510ebfc9f8565fc8cec92955b63...