Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2830993002:
[MD settings] Prevent distortion of icons in cramped UI (Closed)
|
Created:
3 years, 8 months ago by dschuyler Modified:
3 years, 8 months ago Reviewers:
hcarmona CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] Prevent distortion of icons in cramped UI
This CL is a CSS change to stop iron-icons from shrinking when the UI
becomes crowded.
BUG=713046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2830993002
Cr-Commit-Position: refs/heads/master@{#466092}
Committed: https://chromium.googlesource.com/chromium/src/+/64baf346da1faee0f9779b681c67f74c810dfe5b
Patch Set 1 #
Total comments: 3
Messages
Total messages: 15 (9 generated)
Description was changed from ========== [MD settings] Prevent distortion of icons in cramped UI This CL is a CSS change to stop iron-icons from shrinking when the UI becomes crowded. BUG=713046 ========== to ========== [MD settings] Prevent distortion of icons in cramped UI This CL is a CSS change to stop iron-icons from shrinking when the UI becomes crowded. BUG=713046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
dschuyler@chromium.org changed reviewers: + hcarmona@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2830993002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2830993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:36: flex-shrink: 0; /* Prevent distortion of icons in cramped UI. */ Are icons allowed to grow? should this just be flex: 0;
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
https://codereview.chromium.org/2830993002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2830993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:36: flex-shrink: 0; /* Prevent distortion of icons in cramped UI. */ On 2017/04/20 00:48:03, hcarmona wrote: > Are icons allowed to grow? should this just be flex: 0; Using flex: 0; causes the icon to disappear. flex can be used to set the flex grow, shrink, and basis in one go. To prevent growing, I think a grow of zero would be needed (or not using flex). Either way, growing hasn't been an issue that I'm aware of.
lgtm https://codereview.chromium.org/2830993002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2830993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:36: flex-shrink: 0; /* Prevent distortion of icons in cramped UI. */ On 2017/04/20 01:24:56, dschuyler wrote: > On 2017/04/20 00:48:03, hcarmona wrote: > > Are icons allowed to grow? should this just be flex: 0; > > Using flex: 0; causes the icon to disappear. flex can be used to set the flex > grow, shrink, and basis in one go. To prevent growing, I think a grow of zero > would be needed (or not using flex). Either way, growing hasn't been an issue > that I'm aware of. Acknowledged.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492713832557920, "parent_rev":
"75a6cc514e06cd92ccf0689898e15c6d2b6fca16", "commit_rev":
"64baf346da1faee0f9779b681c67f74c810dfe5b"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] Prevent distortion of icons in cramped UI This CL is a CSS change to stop iron-icons from shrinking when the UI becomes crowded. BUG=713046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] Prevent distortion of icons in cramped UI This CL is a CSS change to stop iron-icons from shrinking when the UI becomes crowded. BUG=713046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2830993002 Cr-Commit-Position: refs/heads/master@{#466092} Committed: https://chromium.googlesource.com/chromium/src/+/64baf346da1faee0f9779b681c67... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/64baf346da1faee0f9779b681c67... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
