Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock implementation

Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock implementation

TestSurfaceReferneceFactory currently takes pointers to stack variables 
of a test and apparently writes to them when the stack is gone. This
has caused flakiness on some bots. A mock interface allows us to avoid
doing the nasty stuff with pointers and is generally nicer.

BUG=703263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830983004
Cr-Commit-Position: refs/heads/master@{#466160}
Committed: https://chromium.googlesource.com/chromium/src/+/76209400f9091745a4ecc635223c5e9a86c96939

[Saman Sami, 2017-04-20 21:16:52]

Description was changed from

==========
Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock
implementation
==========

to

==========
Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock
implementation
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-04-20 21:17:05]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 21:17:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-20 21:22:48]

Description was changed from

==========
Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock
implementation
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock
implementation

TestSurfaceReferneceFactory currently takes pointers to stack variables 
of a test and apparently writes to them when the stack is gone. This
has caused flakiness on some bots. A mock interface allows us to avoid
doing the nasty stuff with pointers and is generally nicer.

BUG=703263

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-04-20 21:24:18]

samans@chromium.org changed reviewers:
+ danakj@chromium.org

[Saman Sami, 2017-04-20 21:24:18]

PTAL

[commit-bot: I haz the power, 2017-04-20 21:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:38:35]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-04-20 21:40:36]

LGTM

https://codereview.chromium.org/2830983004/diff/1/cc/layers/surface_layer_uni...
File cc/layers/surface_layer_unittest.cc (right):

https://codereview.chromium.org/2830983004/diff/1/cc/layers/surface_layer_uni...
cc/layers/surface_layer_unittest.cc:241:
testing::Mock::VerifyAndClearExpectations(ref_factory_.get());
Tests will verify mocks implicitly when the mock is destroyed, so I think you
can omit this

[Saman Sami, 2017-04-20 21:45:54]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-04-20 21:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2830983004/#ps20001
(title: "Remove VerifyAndClearExpectations")

[commit-bot: I haz the power, 2017-04-20 21:46:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:12:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492724754905370,
"parent_rev": "7f80c700a7f188fc1aa30713c4a486138f957c69", "commit_rev":
"76209400f9091745a4ecc635223c5e9a86c96939"}

[commit-bot: I haz the power, 2017-04-20 22:12:18]

Description was changed from

==========
Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock
implementation

TestSurfaceReferneceFactory currently takes pointers to stack variables 
of a test and apparently writes to them when the stack is gone. This
has caused flakiness on some bots. A mock interface allows us to avoid
doing the nasty stuff with pointers and is generally nicer.

BUG=703263

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace TestSurfaceReferenceFactory in surface_layer_unittests.cc with a mock
implementation

TestSurfaceReferneceFactory currently takes pointers to stack variables 
of a test and apparently writes to them when the stack is gone. This
has caused flakiness on some bots. A mock interface allows us to avoid
doing the nasty stuff with pointers and is generally nicer.

BUG=703263

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830983004
Cr-Commit-Position: refs/heads/master@{#466160}
Committed:
https://chromium.googlesource.com/chromium/src/+/76209400f9091745a4ecc635223c...
==========

[commit-bot: I haz the power, 2017-04-20 22:12:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76209400f9091745a4ecc635223c...