Obsolete the ozone code path in ui/views/

Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium, 
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone 
implementations, since for Mus/Ozone ScreenMus and 
DesktopWindowTreeHostMus are used, respectively.

BUG=295089
Review-Url: https://codereview.chromium.org/2830933006
Cr-Commit-Position: refs/heads/master@{#466540}
Committed: https://chromium.googlesource.com/chromium/src/+/150a0a9177dc26b6ebbe66f909c0860a49bfb6e1

[tonikitoo, 2017-04-21 19:11:55]

Description was changed from

==========
Obsolete the ozone code path in ui/views/

Ozone works today as an lower level windowing abstract
underneath Mus (UI service). When, we can obsolete the
unused ScreenOzone and DesktopWindowTreeHostOzone implementations,
since for Mus ScreenMus and DesktopWindowTreeHostMus are used, respectively.

BUG=295089
==========

to

==========
Obsolete the ozone code path in ui/views/

Ozone works today as an lower level windowing abstract
underneath Mus (UI service). When, we can obsolete the
unused ScreenOzone and DesktopWindowTreeHostOzone implementations,
since for Mus ScreenMus and DesktopWindowTreeHostMus are used, respectively.

BUG=295089
==========

[tonikitoo, 2017-04-21 19:11:55]

tonikitoo@igalia.com changed reviewers:
+ m@chromium.org, sadrul@chromium.org

[tonikitoo, 2017-04-21 19:12:01]

The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 19:12:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tonikitoo, 2017-04-21 19:15:23]

Description was changed from

==========
Obsolete the ozone code path in ui/views/

Ozone works today as an lower level windowing abstract
underneath Mus (UI service). When, we can obsolete the
unused ScreenOzone and DesktopWindowTreeHostOzone implementations,
since for Mus ScreenMus and DesktopWindowTreeHostMus are used, respectively.

BUG=295089
==========

to

==========
Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium, 
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone 
implementations, since for Mus/Ozone ScreenMus and DesktopWindowTreeHostMus are
used, respectively.

BUG=295089
==========

[tonikitoo, 2017-04-21 19:15:23]

tonikitoo@igalia.com changed reviewers:
+ msw@chromium.org
- m@chromium.org

[tonikitoo, 2017-04-21 19:22:37]

Description was changed from

==========
Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium, 
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone 
implementations, since for Mus/Ozone ScreenMus and DesktopWindowTreeHostMus are
used, respectively.

BUG=295089
==========

to

==========
Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium, 
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone 
implementations, since for Mus/Ozone ScreenMus and 
DesktopWindowTreeHostMus are used, respectively.

BUG=295089
==========

[commit-bot: I haz the power, 2017-04-21 20:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:15:45]

Dry run: This issue passed the CQ dry run.

[tonikitoo, 2017-04-21 20:16:44]

PTAL

[msw, 2017-04-21 21:00:52]

lgtm, but why not remove desktop_window_tree_host_ozone.cc (and
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_ozone.cc) in this
same CL?

[tonikitoo, 2017-04-21 21:15:17]

On 2017/04/21 21:00:52, msw wrote:
> lgtm, but why not remove desktop_window_tree_host_ozone.cc (and
> chrome/browser/ui/views/frame/browser_desktop_window_tree_host_ozone.cc) in
this
> same CL?

Thank you for looking.

These can not be removed now because the there is aura code (x11 and win) that
still calls these method, and are compiled for ozone/mus builds. So we need
these stubs for the sake of compilation.

- DesktopNativeWidgetAura::InitNativeWidget calls 
DesktopWindowTreeHost::Create, but mus (and ozone) code path does not reach it.

- DesktopBrowserFrameAura::InitNativeWidget calls
BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost, but again mus
(and ozone) code path does not reach it.

Maybe they could be renamed from _ozone to _stub suffix, so that it is clear
that they are should not be executed.

[msw, 2017-04-21 21:29:29]

On 2017/04/21 21:15:17, tonikitoo wrote:
> On 2017/04/21 21:00:52, msw wrote:
> > lgtm, but why not remove desktop_window_tree_host_ozone.cc (and
> > chrome/browser/ui/views/frame/browser_desktop_window_tree_host_ozone.cc) in
> this
> > same CL?
> 
> Thank you for looking.
> 
> These can not be removed now because the there is aura code (x11 and win) that
> still calls these method, and are compiled for ozone/mus builds. So we need
> these stubs for the sake of compilation.
> 
> - DesktopNativeWidgetAura::InitNativeWidget calls 
> DesktopWindowTreeHost::Create, but mus (and ozone) code path does not reach
it.
> 
> - DesktopBrowserFrameAura::InitNativeWidget calls
> BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost, but again
mus
> (and ozone) code path does not reach it.
> 
> Maybe they could be renamed from _ozone to _stub suffix, so that it is clear
> that they are should not be executed.

Even better would be excluding those function declaration and calls on those
platforms, so we don't need the stubs. All of these ideas are fine for followup,
this CL looks good as-is.

[tonikitoo, 2017-04-22 13:55:42]

The CQ bit was checked by tonikitoo@igalia.com

[commit-bot: I haz the power, 2017-04-22 13:55:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 19:13:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492869342672330, "parent_rev":
"6e4da46b88046efacaf1850aa3b716aa11a51652", "commit_rev":
"150a0a9177dc26b6ebbe66f909c0860a49bfb6e1"}

[commit-bot: I haz the power, 2017-04-22 19:13:29]

Description was changed from

==========
Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium, 
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone 
implementations, since for Mus/Ozone ScreenMus and 
DesktopWindowTreeHostMus are used, respectively.

BUG=295089
==========

to

==========
Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium, 
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone 
implementations, since for Mus/Ozone ScreenMus and 
DesktopWindowTreeHostMus are used, respectively.

BUG=295089

Review-Url: https://codereview.chromium.org/2830933006
Cr-Commit-Position: refs/heads/master@{#466540}
Committed:
https://chromium.googlesource.com/chromium/src/+/150a0a9177dc26b6ebbe66f909c0...
==========

[commit-bot: I haz the power, 2017-04-22 19:13:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/150a0a9177dc26b6ebbe66f909c0...